From owner-freebsd-current@freebsd.org Wed Aug 29 23:42:17 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB84E1089910 for ; Wed, 29 Aug 2018 23:42:16 +0000 (UTC) (envelope-from ian.freislich@capeaugusta.com) Received: from mail-yw1-xc43.google.com (mail-yw1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8EB7987183 for ; Wed, 29 Aug 2018 23:42:16 +0000 (UTC) (envelope-from ian.freislich@capeaugusta.com) Received: by mail-yw1-xc43.google.com with SMTP id n21-v6so2702257ywh.5 for ; Wed, 29 Aug 2018 16:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=capeaugusta-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=8C/kBbveXiSJMrk7s/w5zUIyK8nzamGkYi82Lobb76Q=; b=itKERilgC30AJgfWersVRW2xCBfsdYruSa+jCJhJTOYfl2ShPkrawRu8jR1FEE8zR4 xoa1oSit54IrgAuEp7nnJJ2JdEQMaL431uTYJn/Rtdthz+iGbUT7z7DrdkiZz7cJuieE UBJ19Swved4Okzxr/GhCtAHCzcYHfPGptptJZiA1DIhsCT4G6YdpXqGjsF5lyJ0msGQG aMUt2m23S/dX45o14/kvlSSK/gLkz+dpNGEHiyMrgGtSfVdGCRDTydA+IF2IRBfA6eME 0cjYO2sIGAETLxXNk2eNNAXs7kHQkF1q09dptxyTo0r7WNW6Nu1XkRq04aDD9XPBvAd9 RK0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=8C/kBbveXiSJMrk7s/w5zUIyK8nzamGkYi82Lobb76Q=; b=ruWfgBiMMDAts+nMSAVAh9fnEBGjMOg5lLXENFJ+EBVnATIN/i3Ff1R/DnM0KhAg0V /lZ6SmeT/toW297raT+WpT1g8zb3XMl+WdnlFAIhJ6C18M0fWDD8Mqkd+VIifws6fLoU LkLR5MT9A/1cxxRCvVISecD19tkuE3ULKhFtTtfq4RxtLTNr3TePUpzXYzZU+VNviBx4 f5y3RL3NstPTxYWkZo2RmW1vUWyCMNt31/Wcwul8tuLKQdPCTOXuRcdr5VXwOisx8Qy5 pRH62fGO+Z2TCdScveHh3S0AVNNrU+lVfYMWNTe0nzeMgFIoQlQhHIE3Lgc3xwNSQeAJ p1IA== X-Gm-Message-State: APzg51BroaZPfUzjKCNnwpSfvCAnA3kjU2VJZFRZEK84TyDOcdu44mRU 8RKRa00pRr6e6JT9227heEuEtMz+re0Ylos+MeSHWw9aJ48XMpK+FGcY7hXfFCRw1STdkTj3qlC hMm3NYAaXIZIj8NjPAEPBe+rJID/t169hWLLHkLKTgoqL4i+k8WcGt91bp8KA68VDna3micd2BU TPiYtvwsNRtq0= X-Google-Smtp-Source: ANB0VdbnwVn5XuLKuuC5ks5ncICDN3hfyBv08gtFiaXBhllZU5anfgGiX+oSzemKfR2azi3yLcacHA== X-Received: by 2002:a81:4e17:: with SMTP id c23-v6mr4740707ywb.229.1535586135697; Wed, 29 Aug 2018 16:42:15 -0700 (PDT) Received: from [10.0.0.99] (c-69-254-3-228.hsd1.ga.comcast.net. [69.254.3.228]) by smtp.gmail.com with ESMTPSA id l127-v6sm2440876ywc.5.2018.08.29.16.42.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Aug 2018 16:42:15 -0700 (PDT) Subject: Re: intr_machdep.c:176:2: error: use of undeclared identifier 'interrupt_sorted' To: John Baldwin , freebsd-current References: <524214ac-e3ca-53cd-aee3-dac9212e9800@capeaugusta.com> <0aa35f96-9f62-bfca-c04a-f6ddcb1ce738@FreeBSD.org> From: Ian FREISLICH Message-ID: <5efd5c70-7672-8acb-747c-113806f47fcb@capeaugusta.com> Date: Wed, 29 Aug 2018 19:42:14 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <0aa35f96-9f62-bfca-c04a-f6ddcb1ce738@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 23:42:17 -0000 I moved the #ifdef down one line and its compiling. Ian --=20 Ian Freislich On 08/29/2018 07:40 PM, John Baldwin wrote: > On 8/29/18 4:20 PM, Ian FREISLICH wrote: >> Hi >> >> I see the definition of interrupt_sorted is #ifdefed out by #ifdef SMP >> at line 84.=C2=A0 My system is UP so I'm not compiling an SMP ker= nel. >> >> /usr/src/sys/x86/x86/intr_machdep.c:176:2: error: use of undeclared >> identifier 'interrupt_sorted'; did you mean 'interrupt_sources'? >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 interrupt_sorted =3D mallocar= ray(num_io_irqs, >> sizeof(*interrupt_sorted), >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~~~~~~ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 interrupt_sources >> /usr/src/sys/x86/x86/intr_machdep.c:83:24: note: 'interrupt_sources' >> declared here >> static struct intsrc **interrupt_sources; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ >> /usr/src/sys/x86/x86/intr_machdep.c:176:54: error: use of undeclared >> identifier 'interrupt_sorted'; did you mean 'interrupt_sources'? >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 interrupt_sorted =3D mallocar= ray(num_io_irqs, >> sizeof(*interrupt_sorted), > Probably just needs #ifdef SMP around the mallocarray(). I'll test local= lyon a UP kernel config. > --=20