Date: Wed, 10 Jul 2013 11:34:51 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Claude Buisson <clbuisson@orange.fr> Cc: rmacklem@freebsd.org, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: (follow-up) "Stale NFS file handle" for NFS exported UFS from r252435 Message-ID: <51DD8D2B.60509@FreeBSD.org> In-Reply-To: <51DD7AB1.4090202@orange.fr> References: <51DD5451.2010801@orange.fr> <51DD6777.90803@orange.fr> <51DD782E.7090503@FreeBSD.org> <51DD7AB1.4090202@orange.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------080203060808070404040503 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 10.07.2013 10:16, Claude Buisson wrote: > On 07/10/2013 17:05, Pedro Giffuni wrote: >> Hello guys; >> >> Thank for finding this, however ... >> > > <snip> > >> >> While I understand this change caused the issue and I am willing to >> revert it, >> I think the problem is actually in NFS. At least ext2/3/4 and fuse (so I >> presume >> glusterfs) have unsigned i_gen. >> > > I have the same thinking (and was rather astonished by the success of > my try at > reverting it): there is something somewhere in the NFS code which have > not been > synced with the UFS change. > > It is the reason I CC'ed rmacklem@ > >> Pedro. >> > > Claude Buisson > I found a missing type change. Can you try the attached patch? Cheers, Pedro. --------------080203060808070404040503 Content-Type: text/plain; charset=UTF-8; name="patch-unsigned-ufid_gen" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="patch-unsigned-ufid_gen" Index: sys/ufs/ufs/inode.h =================================================================== --- sys/ufs/ufs/inode.h (revision 253159) +++ sys/ufs/ufs/inode.h (working copy) @@ -180,7 +180,7 @@ u_int16_t ufid_len; /* Length of structure. */ u_int16_t ufid_pad; /* Force 32-bit alignment. */ uint32_t ufid_ino; /* File number (ino). */ - int32_t ufid_gen; /* Generation number. */ + uint32_t ufid_gen; /* Generation number. */ }; #endif /* _KERNEL */ --------------080203060808070404040503--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51DD8D2B.60509>