From owner-cvs-src@FreeBSD.ORG  Sun Feb 24 11:07:30 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C6DD816A402;
	Sun, 24 Feb 2008 11:07:30 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 8432513C4F5;
	Sun, 24 Feb 2008 11:07:30 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 00A7A46B42;
	Sun, 24 Feb 2008 06:07:30 -0500 (EST)
Date: Sun, 24 Feb 2008 11:07:29 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Colin Percival <cperciva@FreeBSD.org>
In-Reply-To: <200802240007.m1O071xr052282@repoman.freebsd.org>
Message-ID: <20080224110613.X25292@fledge.watson.org>
References: <200802240007.m1O071xr052282@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Feb 2008 11:07:30 -0000

On Sun, 24 Feb 2008, Colin Percival wrote:

> cperciva    2008-02-24 00:07:00 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/kern             uipc_syscalls.c
>  Log:
>  After finishing sending file data in sendfile(2), don't forget to send
>  the provided trailers.  This has been broken since revision 1.240.

Nice work tracking this down -- it sounds like the perfect candidate for a 
regression test.  Over the last year or two, we've been working hard to 
populate src/tools/regression/sockets with various test cases, and it sounds 
like the sendfile tests there could use some fleshing out, since we've now 
seen several rather significant functional regressions over the last few 
years.  Any chance we can get you to take a look at doing that as well? :-)

Robert N M Watson
Computer Laboratory
University of Cambridge