From owner-freebsd-hackers  Wed Jan  8 16:20:22 1997
Return-Path: <owner-hackers>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.4/8.8.4) id QAA12945
          for hackers-outgoing; Wed, 8 Jan 1997 16:20:22 -0800 (PST)
Received: from pdx1.world.net (pdx1.world.net [192.243.32.18])
          by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id QAA12939
          for <hackers@freebsd.org>; Wed, 8 Jan 1997 16:20:20 -0800 (PST)
From: proff@suburbia.net
Received: from suburbia.net (suburbia.net [203.4.184.1]) by pdx1.world.net (8.7.5/8.7.3) with SMTP id QAA02361 for <hackers@freebsd.org>; Wed, 8 Jan 1997 16:21:06 -0800 (PST)
Received: (qmail 25946 invoked by uid 110); 9 Jan 1997 00:19:45 -0000
Message-ID: <19970109001944.25945.qmail@suburbia.net>
Subject: Re: <sys/queue.h> potential for panic
In-Reply-To: <Pine.SV4.3.95.970109083859.16689B-100000@parkplace.cet.co.jp> from Michael Hancock at "Jan 9, 97 08:57:31 am"
To: michaelh@cet.co.jp (Michael Hancock)
Date: Thu, 9 Jan 1997 11:19:44 +1100 (EST)
Cc: hackers@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL28 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-hackers@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

> On Wed, 1 Jan 1997, Poul-Henning Kamp wrote:
> 
> > 
> > TAILQ_REMOVE and STAILQ_REMOVE would panic with a zero dereference
> > if you tried to remove something not on the queue.
> > 
> > Wouldn't it make sense to avoid that, or would the overhead be considered
> > prohibitive ?

#ifdef DIAGNOSTIC
check
#endif

is what it needs

-Julian <proff@iq.org>