From owner-svn-ports-head@freebsd.org  Mon Sep 17 15:36:34 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D694510A073F;
 Mon, 17 Sep 2018 15:36:34 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8DCF780ABB;
 Mon, 17 Sep 2018 15:36:34 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 85D181172B; Mon, 17 Sep 2018 15:36:34 +0000 (UTC)
Date: Mon, 17 Sep 2018 15:36:34 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r479028 - head/games/yadex
Message-ID: <20180917153634.GA60182@FreeBSD.org>
References: <201809051631.w85GVdwR029041@repo.freebsd.org>
 <20180905214947.3msj2lkffek66vbo@atuin.in.mat.cc>
 <20180906133003.GA14967@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180906133003.GA14967@FreeBSD.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 15:36:35 -0000

On Thu, Sep 06, 2018 at 01:30:03PM +0000, Alexey Dokuchaev wrote:
> On Wed, Sep 05, 2018 at 11:49:47PM +0200, Mathieu Arnold wrote:
> > On Wed, Sep 05, 2018 at 04:31:39PM +0000, Alexey Dokuchaev wrote:
> > > New Revision: 479028
> > > URL: https://svnweb.freebsd.org/changeset/ports/479028
> > > 
> > > Log:
> > >   Consummate conversion to option helpers (should've been part of
> > >   r479022).
> > > 
> > > Modified: head/games/yadex/Makefile
> > > @@ -37,17 +37,10 @@ PATCH_SUFFIX=	.diff
> > >  PATCHFILES=	${PATCH_PREFIX}_Depend${PATCH_SUFFIX}
> > >  
> > >  3D_RENDER_PATCHFILES=	${PATCH_PREFIX}_Render3D${PATCH_SUFFIX}
> > > +3D_RENDER_PORTDOCS=	preview.html
> > 
> > This is missing a 3D_RENDER_IMPLIES=DOCS.
> 
> I don't think so, why?  One of the nice things about PORTDOCS that is can
> (and should) be set unconditionally (independent of DOCS).  In fact, I
> could have simply got away with PORTDOCS=* but I prefer to avoid globbing.
> 
> If you build the package with OPTIONS_UNSET=DOCS and OPTIONS_DEFAULT=
> 3D_RENDER you'll see that the package is generated correctly (without the
> docfiles).

I see you've jumped over and added this in r479406.  This is not how we
do things in FreeBSD.  Either back it out or reply to my reasoning above
with proper explanation of where and why I'm wrong.

./danfe