From owner-freebsd-current@FreeBSD.ORG Wed Apr 29 12:49:05 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5AC471065686; Wed, 29 Apr 2009 12:49:05 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id EE0B28FC14; Wed, 29 Apr 2009 12:49:04 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1Lz9Dh-0003ak-Pe; Wed, 29 Apr 2009 15:49:02 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n3TCmw9o048770 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 29 Apr 2009 15:48:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n3TCmwXK084416; Wed, 29 Apr 2009 15:48:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n3TCmvEe084415; Wed, 29 Apr 2009 15:48:57 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 29 Apr 2009 15:48:57 +0300 From: Kostik Belousov To: jeff@freebsd.org Message-ID: <20090429124857.GD40751@deviant.kiev.zoral.com.ua> References: <20090429104651.8CE537302F@freebsd-current.sentex.ca> <49F8460F.7030506@incunabulum.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yda//aIZIMrd7mir" Content-Disposition: inline In-Reply-To: <49F8460F.7030506@incunabulum.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1Lz9Dh-0003ak-Pe 22050f8afb54dfd441afbd4797b2eb4d X-Terabit: YES Cc: Bruce Simpson , pluknet , current@freebsd.org Subject: Re: [head tinderbox] failure on powerpc/powerpc X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2009 12:49:06 -0000 --yda//aIZIMrd7mir Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 29, 2009 at 01:20:31PM +0100, Bruce Simpson wrote: > pluknet wrote: > >... > >>/src/sys/kern/sched_ule.c: In function 'sched_idletd': > >>/src/sys/kern/sched_ule.c:2546: error: dereferencing pointer to=20 > >>incomplete type > >>/src/sys/kern/sched_ule.c:2546: error: 'CG_FLAG_THREAD' undeclared (fir= st=20 > >>use in this function) > >>/src/sys/kern/sched_ule.c:2546: error: (Each undeclared identifier is= =20 > >>reported only once > >>/src/sys/kern/sched_ule.c:2546: error: for each function it appears in.) > >>*** Error code 1 > >> > >> =20 > > > >This is the only arch without "options SMP" in GENERIC. > >Global NOTES also define options SCHED_4BSD and thus > >does not trigger the error (CG_FLAG_THREAD in SMP scope). > > > > =20 > +1, I just saw this on a 'make universe' run affecting the ARM targets. >=20 > BMS The following works for me. The tdq_idled() definition may be #ifdef SMP too, but I do not see a point. THe CG_FLAG_THREAD is used in sched_idletd(), and adding more #ifdef SMP would make the code more ugly without any gain. diff --git a/sys/sys/smp.h b/sys/sys/smp.h index 05c8642..293f07d 100644 --- a/sys/sys/smp.h +++ b/sys/sys/smp.h @@ -16,8 +16,6 @@ =20 #ifndef LOCORE =20 -#ifdef SMP - /* * Topology of a NUMA or HTT system. * @@ -57,6 +55,7 @@ struct cpu_group { #define CG_FLAG_SMT 0x02 /* New age htt, less crippled. */ #define CG_FLAG_THREAD (CG_FLAG_HTT | CG_FLAG_SMT) /* Any threading. */ =20 +#ifdef SMP /* * Convenience routines for building topologies. */ --yda//aIZIMrd7mir Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkn4TLkACgkQC3+MBN1Mb4hUvgCfWTWtdqqPTA71AAU9yUBspkch z5oAnjMFPJsM44vQk0cdWZk8Zh+5x9/q =mLFS -----END PGP SIGNATURE----- --yda//aIZIMrd7mir--