Date: Fri, 3 Jan 2020 10:01:22 -0800 From: Devin Teske <dteske@freebsd.org> To: Adriaan de Groot <adridg@freebsd.org> Cc: Devin Teske <dteske@freebsd.org>, Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r521892 - in head/math: . R-cran-alabama Message-ID: <29C42407-97B1-4DDB-BEC3-DB397ECD85C7@freebsd.org> In-Reply-To: <2968169.bT80LyP3VS@beastie.bionicmutton.org> References: <202001030056.0030umrE001847@repo.freebsd.org> <20200103083628.b7b2b46pea33vu5f@atuin.in.mat.cc> <2968169.bT80LyP3VS@beastie.bionicmutton.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 3, 2020, at 06:50, Adriaan de Groot <adridg@freebsd.org> wrote: >=20 > On Friday, 3 January 2020 09:36:28 CET Mathieu Arnold wrote: >> On Fri, Jan 03, 2020 at 12:56:48AM +0000, Devin Teske wrote: >>> Author: dteske (src committer) >>=20 >> As stated by this ^^^^^^^^^^^^^ you are not a ports committer. So = you >> are required to get approval, and state the approval in your commits, >> saying it has been reviewed is not enough. >>=20 >>> Reviewed by: mat, imp (previous revision) >>> Differential Revision: https://reviews.freebsd.org/D22675 >=20 > Question for mat@, just to be clear: the issue here is (only) that = there=20 > should be an extra line in the commit message, > Approved by: mat > or possibly > Approved by: mat (mentor) > as described in the committer's guide [1]. >=20 > The Phab review was approved (accepted), so it's just the = documentation of=20 > process?=20 >=20 >=20 > [1] = https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ > commit-log-message.html >=20 The process is broken currently as I=E2=80=99ve been denied a ports = commit bit and my mentorship is null and void for a ports bit. I do not not know how to navigate such a situation. In this case, would review be akin to approval and thus, whomsoever = reviewed it that is an active ports committer is therefore the approver? =E2=80=94=20 Devin=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?29C42407-97B1-4DDB-BEC3-DB397ECD85C7>