From owner-freebsd-arch@FreeBSD.ORG Sun Mar 17 16:45:01 2013 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id B6B92BF for ; Sun, 17 Mar 2013 16:45:01 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id 80FE197F for ; Sun, 17 Mar 2013 16:45:00 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id CCF5F267; Sun, 17 Mar 2013 17:41:44 +0100 (CET) Date: Sun, 17 Mar 2013 17:46:33 +0100 From: Pawel Jakub Dawidek To: Konstantin Belousov Subject: Re: chflags(2)'s flags argument. Message-ID: <20130317164632.GI1364@garage.freebsd.pl> References: <20130317003559.GA1364@garage.freebsd.pl> <20130317064123.GM3794@kib.kiev.ua> <20130317111112.GC1364@garage.freebsd.pl> <20130317155743.GR3794@kib.kiev.ua> <20130317162021.GG1364@garage.freebsd.pl> <20130317162533.GT3794@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ev7mvGV+3JQuI2Eo" Content-Disposition: inline In-Reply-To: <20130317162533.GT3794@kib.kiev.ua> X-OS: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-arch@FreeBSD.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Mar 2013 16:45:01 -0000 --ev7mvGV+3JQuI2Eo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 17, 2013 at 06:25:33PM +0200, Konstantin Belousov wrote: > On Sun, Mar 17, 2013 at 05:20:22PM +0100, Pawel Jakub Dawidek wrote: > > On Sun, Mar 17, 2013 at 05:57:43PM +0200, Konstantin Belousov wrote: > > > On Sun, Mar 17, 2013 at 12:11:12PM +0100, Pawel Jakub Dawidek wrote: > > > > I know it can break API in some rare cases like in chflags(1), but = it > > > > results in compilation error (at least with the compilation flags we > > > > use), so can be easly spotted and fixed, hopefully: > > > >=20 > > > > /usr/home/pjd/p4/capkern/bin/chflags/chflags.c: In function 'main': > > > > /usr/home/pjd/p4/capkern/bin/chflags/chflags.c:120: warning: assign= ment from incompatible pointer type > > > >=20 > > >=20 > > > Project aims to maintain better compatibility then to claim that > > > the changes could be 'spotted'. > >=20 > > Should I read this as you being against the proposed change? >=20 > No, I do not object. But, did you considered changing the syscall argument > to unsigned long instead ? Well, the main reason behind this change is to make all chflags(2) syscalls consistent. I didn't consider changing syscall argument to unsigned long, but then I'd need to update lchflags(2) to take unsigned long to make it consistent with others, which has the exact same implications. Now that I think about this, changing lchflags(2) argument to unsigned long might be better option, because: - It would make all those syscalls consistent with strtofflags(3) and fflagstostr(3). - It would decrease the risk of possible breakage, as lchflags(2) is rarely used. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --ev7mvGV+3JQuI2Eo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFF82gACgkQForvXbEpPzRvxwCfXDczTJTta1E81k0//4aONOyq CNcAoM+o5+jscnGRgejEWfzmLbTjxU2z =X6V/ -----END PGP SIGNATURE----- --ev7mvGV+3JQuI2Eo--