From nobody Sun Aug 9 17:01:43 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hJ4145Vxkz6nlqP for ; Sun, 09 Aug 2026 17:01:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hJ4135jTSz3lmb for ; Sun, 09 Aug 2026 17:01:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786294903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YIJzb+AACYTFC7taqDPsSWa3aTgNQSyQojMXuk7XkPQ=; b=Y+RHRX3U+Octl0GlJ032a52zD2trprVCSSOvt+JYfiHCk6bT1zQtSxhyswOUXMaYWxp3F7 RuL3IcFwf+kPzhzfUH2rz3B+tlzP3Uz9SOyb87FaiLHup5nTgBMa3fGpSIIpnLpzsJvBmZ qcTVHmUaLNpmsyhUWOOL2H64eo/r+ctSBECiF6ckGyhNVUtMapM3lBVJmdY9d0WF8ay+L8 cXFug0P0GlFF696RR+84mcismgjyEEZ5MElpYacdyioW2NhfhBvjBbmo8ARxPvKRVZKjJk RRK+zvA6rAjlDWZXEuNC4PpLgmP3qaMV0sbTiidmdhBuIr+7UX1CU+8P6nLGVQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786294903; a=rsa-sha256; cv=none; b=EaJalqBqx0WAw9kUQsRAoZZUAxdPwUqIgujVVvEVNcYnXEq0WGxeGH8MwRYZzrRWzzV0W1 d2h+ZV0dlX3XzUwGqiB1GvJFHqJnIH6yeLdYhJXB36gbUmH5wh3Phm6GPZRun7GjonSpgT NjnMqn5dffp94lYe7TOGxzW3bohkv2pRP/gdN0ugdUDp2LOp/8t7njNGID5+MSv/odmn9O Jh+iHrvSBqpmVuZ9kJTRJSvIBgk5x+RZQmyY3XLWmv6lxjL+XlhglKmsAQhX0RpI1T+jgS +rwYupWA4er2pDwZTlTzA3zs/f11O/W22fn1xMje0fAVJgBqw2YS8KiCCgYV/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786294903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YIJzb+AACYTFC7taqDPsSWa3aTgNQSyQojMXuk7XkPQ=; b=FR3Nle6f5I/XUNlygQfqIX6jQ7NUgDb0Mc1ze3XiAmF57OShlc+btEnb+io1wGX2k6Dg+A Yt8WCmhHVbU1JB3w5W04c0eOkhFd2A40nSmH9hEfzi4XygJwZx74BNWlIYJnXsghHMDhXP P558Adhgf4az/Abqx9bDz0XYfFwMFcHkqyeydZupzKfawwRywbwi4DsLp7EXDjQdB5Tdnf ejybERuME3sgZ/OOq4dwYmVDneuojqLxKvXyWGnL9UxXYlxPvhFYl4e/lKGjnUrAFR8r+3 pVGyx/S1rp6YfnwHaUoj5K0q09sW5pvAiWpXnmMtyXwvI6K6JFy1yMNWTzQecA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hJ4134SJmzY2S for ; Sun, 09 Aug 2026 17:01:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 399dc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 09 Aug 2026 17:01:43 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Abdelkader Boudih From: Adrian Chadd Subject: git: a8165edb50ab - main - fwcam: release the IR DMA channel when starting the stream fails List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a8165edb50ab323241fa622f720d724bc5f22150 Auto-Submitted: auto-generated Date: Sun, 09 Aug 2026 17:01:43 +0000 Message-Id: <6a78b277.399dc.22a42952@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=a8165edb50ab323241fa622f720d724bc5f22150 commit a8165edb50ab323241fa622f720d724bc5f22150 Author: Abdelkader Boudih AuthorDate: 2026-08-09 16:59:26 +0000 Commit: Adrian Chadd CommitDate: 2026-08-09 16:59:29 +0000 fwcam: release the IR DMA channel when starting the stream fails Disabled the IR DMA channel on the error path, which clears the flag and frees the descriptor blocks before the chunks go away. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D58502 --- sys/dev/firewire/fwcam.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/dev/firewire/fwcam.c b/sys/dev/firewire/fwcam.c index c98eb7a9894c..e2b53935597b 100644 --- a/sys/dev/firewire/fwcam.c +++ b/sys/dev/firewire/fwcam.c @@ -534,6 +534,9 @@ fwcam_iso_start(struct fwcam_softc *sc) return (0); fail: + if (xferq->flag & FWXFERQ_RUNNING) + fc->irx_disable(fc, dma_ch); + fw_iso_free_chunks(xferq, M_FWCAM); xferq->flag &= ~(FWXFERQ_MODEMASK | FWXFERQ_OPEN | FWXFERQ_STREAM | FWXFERQ_EXTBUF | FWXFERQ_HANDLER | FWXFERQ_CHTAGMASK);