From owner-freebsd-bugs@FreeBSD.ORG  Wed Aug  6 10:30:27 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4753837B425
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  6 Aug 2003 10:30:27 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2753543FDD
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  6 Aug 2003 10:30:12 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h76HUBUp042966
	for <freebsd-bugs@freefall.freebsd.org>;
	Wed, 6 Aug 2003 10:30:11 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h76HUBgB042965;
	Wed, 6 Aug 2003 10:30:11 -0700 (PDT)
Date: Wed, 6 Aug 2003 10:30:11 -0700 (PDT)
Message-Id: <200308061730.h76HUBgB042965@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Bruce M Simpson <bms@spc.org>
Subject: Re: bin/55124: [PATCH] request total incorrectly reported by
	vmstat(8)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Bruce M Simpson <bms@spc.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Aug 2003 17:30:28 -0000

The following reply was made to PR bin/55124; it has been noted by GNATS.

From: Bruce M Simpson <bms@spc.org>
To: David Schultz <das@FreeBSD.ORG>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/55124: [PATCH] request total incorrectly reported by vmstat(8)
Date: Wed, 6 Aug 2003 18:26:29 +0100

 On Mon, Aug 04, 2003 at 11:23:23PM -0700, David Schultz wrote:
 > > 	Under RELENG_4, the running total of requests for each subsystem
 > > 	client of the vm (vmstat -m) is incorrectly reported due to the use
 > > 	of a signed (vs unsigned) integer.
 > [...]
 > > -	long totuse = 0, totfree = 0, totreq = 0;
 > > +	long totuse = 0, totfree = 0;
 > > +	unsigned long totreq = 0;
 > 
 > This only buys you a factor of 2, then it overflows again.  totreq
 > should be a uint64_t like the ks_calls values it's accumulating.
 
 Agreed, it is a purely symptomatic fix for the user's problem...
 
 PS Are you stalking my PRs or something? :-) If so, please look at
 the conf/* ones if you have time...
 
 BMS