From owner-cvs-all  Mon May 28  8:41: 0 2001
Delivered-To: cvs-all@freebsd.org
Received: from henny.webweaving.org (gate.qubesoft.com [212.113.16.243])
	by hub.freebsd.org (Postfix) with ESMTP
	id EF84C37B422; Mon, 28 May 2001 08:40:50 -0700 (PDT)
	(envelope-from n_hibma@FreeBSD.ORG)
Received: from localhost (localhost [127.0.0.1])
	by henny.webweaving.org (8.11.3/8.11.3) with ESMTP id f4SFedu96771;
	Mon, 28 May 2001 16:40:40 +0100 (BST)
	(envelope-from n_hibma@FreeBSD.ORG)
Date: Mon, 28 May 2001 16:40:39 +0100 (BST)
From: <n_hibma@FreeBSD.ORG>
X-X-Sender:  <n_hibma@henny.webweaving.org>
To: Bruce Evans <bde@zeta.org.au>
Cc: Poul-Henning Kamp <phk@FreeBSD.ORG>,
	<cvs-committers@FreeBSD.ORG>, <cvs-all@FreeBSD.ORG>
Subject: Re: cvs commit: src/sys/kern subr_disk.c
In-Reply-To: <Pine.BSF.4.21.0105282255010.2091-100000@besplex.bde.org>
Message-ID: <20010528163852.X96112-100000@henny.webweaving.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


In my case I do use devfs, but it isn't mounted through fstab, but
implicitly by init it seems.

$ mount | grep devfs
devfs on /dev (devfs, local)


Nick


> > Reverting this commit avoids the panic I just mailed you. No idea why.
> >
> > Anything you want me to try to look into this? Little problem is that I
> > don't have a serial console and the panic happens before dumpdev is set.
>
> This may be related to rev.1.38 of subr_disk.c breaking most disk devices
> in the non-devfs case.  Their devsw() is 0 so spec_open() returns ENXIO.
> Places that don't check for a null devsw() would just panic.  I think
>
> Bruce
>
> > On Thu, 24 May 2001, Poul-Henning Kamp wrote:
> >
> > > phk         2001/05/24 13:27:17 PDT
> > >
> > >   Modified files:
> > >     sys/kern             subr_disk.c
> > >   Log:
> > >   Don't take the detour around devsw() to find out if the proto-cdevsw
> > >   is already initialized.
> > >
> > >   Revision  Changes    Path
> > >   1.38      +2 -4      src/sys/kern/subr_disk.c
> > >
> > >   http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/kern/subr_disk.c?r1=1.37&r2=1.38&cvsroot=freebsd
>

-- 
The USB for FreeBSD project.
n_hibma@FreeBSD.ORG
http://www.etla.net/~n_hibma/usb/usb.pl


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message