From owner-cvs-all@FreeBSD.ORG Mon Jun 7 18:54:12 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DA2216A4CE; Mon, 7 Jun 2004 18:54:12 +0000 (GMT) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 803A243D48; Mon, 7 Jun 2004 18:54:11 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc12) with ESMTP id <2004060718541001400i3ug1e>; Mon, 7 Jun 2004 18:54:11 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA27327; Mon, 7 Jun 2004 11:54:09 -0700 (PDT) Date: Mon, 7 Jun 2004 11:54:08 -0700 (PDT) From: Julian Elischer To: Tim Robbins In-Reply-To: <20040607082030.GA38464@cat.robbins.dropbear.id.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Julian Elischer cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_kse.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 18:54:12 -0000 On Mon, 7 Jun 2004, Tim Robbins wrote: > On Mon, Jun 07, 2004 at 07:25:03AM +0000, Julian Elischer wrote: > > julian 2004-06-07 07:25:03 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_kse.c > > Log: > > Move the KSE ABI specific code here and separate it from code that > > is generic to any threading system. This commit does not link this > > file to the build yet, nor does it remove these functions from their > > current location in kern_thread.c. (that commit coming up after further review) > > I like what you've done here, but please don't go overboard with the > abstraction -- the KSE code is already very hard to follow and overly > complex, and we would be kidding ourselves if we thought we could support > more than one thread system (I would like to see thr gone before 5.3-STABLE.) > I'm just spliting one file into two to make it more obvious what parts are "Generic thread support" and what parts are "Kse based threading". I regret that I didn't do it this way to start with.. but in this game you can correct some of your mistakes.. When these two are separated there are a few more cleanups, but this change should be almost a NOP as far as running code. > > Tim >