From owner-cvs-share Fri Aug 23 05:40:33 1996 Return-Path: owner-cvs-share Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id FAA14339 for cvs-share-outgoing; Fri, 23 Aug 1996 05:40:33 -0700 (PDT) Received: from mail.cs.tu-berlin.de (root@mail.cs.tu-berlin.de [130.149.17.13]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id FAA14333; Fri, 23 Aug 1996 05:40:21 -0700 (PDT) Received: from caramba.cs.tu-berlin.de (wosch@caramba.cs.tu-berlin.de [130.149.17.12]) by mail.cs.tu-berlin.de (8.6.12/8.6.12) with ESMTP id OAA23714; Fri, 23 Aug 1996 14:15:44 +0200 From: Wolfram Schneider Received: (from wosch@localhost) by caramba.cs.tu-berlin.de (8.7.5/8.7.2) id OAA22685; Fri, 23 Aug 1996 14:15:39 +0200 (MET DST) Date: Fri, 23 Aug 1996 14:15:39 +0200 (MET DST) Message-Id: <199608231215.OAA22685@caramba.cs.tu-berlin.de> To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) Cc: mpp@freefall.freebsd.org (Mike Pritchard), wosch@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-share@freefall.freebsd.org Subject: Re: cvs commit: src/share/man/man9 style.9 In-Reply-To: <199608230710.JAA29339@uriah.heep.sax.de> References: <199608222027.NAA14699@freefall.freebsd.org> <199608230710.JAA29339@uriah.heep.sax.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-cvs-share@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk J. Wunsch writes: >As Mike Pritchard wrote: > >> > remove case '?', if '?' is not in getopt(), it should >> > not be in the switch statement > >> '?' is a valid return value from getopt(), and should probably be >> in the switch statement, even if it is covered by the "default" case. >> Since this is the style guide, including it in the example will >> at least make people think about it. > >Yep. Folks, please discuss modifications to the style guide first. There was a discussion 6 months ago. mv.c revision 1.6 date: 1996/02/19 05:51:13; author: pst; state: Exp; lines: +2 -5 [...] -? is an unnecessary case statement and not useful Wolfram