From owner-freebsd-current@FreeBSD.ORG  Wed Oct 26 09:07:02 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7CD2E16A456
	for <current@freebsd.org>; Wed, 26 Oct 2005 09:07:02 +0000 (GMT)
	(envelope-from pho@holm.cc)
Received: from relay03.pair.com (relay03.pair.com [209.68.5.17])
	by mx1.FreeBSD.org (Postfix) with SMTP id 9A66543D46
	for <current@freebsd.org>; Wed, 26 Oct 2005 09:07:01 +0000 (GMT)
	(envelope-from pho@holm.cc)
Received: (qmail 6323 invoked from network); 26 Oct 2005 09:07:00 -0000
Received: from unknown (HELO peter.osted.lan) (unknown)
	by unknown with SMTP; 26 Oct 2005 09:07:00 -0000
X-pair-Authenticated: 80.161.118.233
Received: from peter.osted.lan (localhost.osted.lan [127.0.0.1])
	by peter.osted.lan (8.13.1/8.13.1) with ESMTP id j9Q96sXl039520;
	Wed, 26 Oct 2005 11:06:54 +0200 (CEST)
	(envelope-from pho@peter.osted.lan)
Received: (from pho@localhost)
	by peter.osted.lan (8.13.1/8.13.1/Submit) id j9Q96s71039519;
	Wed, 26 Oct 2005 11:06:54 +0200 (CEST) (envelope-from pho)
Date: Wed, 26 Oct 2005 11:06:54 +0200
From: Peter Holm <peter@holm.cc>
To: Gleb Smirnoff <glebius@freebsd.org>
Message-ID: <20051026090654.GA39435@peter.osted.lan>
References: <20051026072337.GA31319@peter.osted.lan>
	<20051026083147.GA41520@cell.sick.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051026083147.GA41520@cell.sick.ru>
User-Agent: Mutt/1.4.2.1i
Cc: current@freebsd.org
Subject: Re: panic: mutex nfsd_mtx owned at nfsserver/nfs_serv.c:2160
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2005 09:07:02 -0000

On Wed, Oct 26, 2005 at 12:31:47PM +0400, Gleb Smirnoff wrote:
>   Peter,
> 
> On Wed, Oct 26, 2005 at 09:23:37AM +0200, Peter Holm wrote:
> P> While stress testing RELENG_6_0 with a nfs mounted file system on a 
> P> box running HEAD from Oct 24 13:21 UTC I got this panic (on HEAD):
> P> http://people.freebsd.org/~pho/stress/log/nfsd.html
> 
> let's try out this one.
> 

Wow, that was fast! Meanwhile here's another fifo related panic on
HEAD ;-)

http://people.freebsd.org/~pho/stress/log/nfsd2.html

- Peter

> -- 
> Totus tuus, Glebius.
> GLEBIUS-RIPN GLEB-RIPE

> Index: nfs_serv.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/nfsserver/nfs_serv.c,v
> retrieving revision 1.156
> diff -u -r1.156 nfs_serv.c
> --- nfs_serv.c	17 Apr 2005 16:25:36 -0000	1.156
> +++ nfs_serv.c	26 Oct 2005 08:00:26 -0000
> @@ -2092,6 +2092,7 @@
>  	tl = nfsm_dissect_nonblock(u_int32_t *, NFSX_UNSIGNED);
>  	vtyp = nfsv3tov_type(*tl);
>  	if (vtyp != VCHR && vtyp != VBLK && vtyp != VSOCK && vtyp != VFIFO) {
> +		NFSD_UNLOCK();
>  		error = NFSERR_BADTYPE;
>  		goto out;
>  	}
> @@ -2108,6 +2109,7 @@
>  	 * Iff doesn't exist, create it.
>  	 */
>  	if (nd.ni_vp) {
> +		NFSD_UNLOCK();
>  		error = EEXIST;
>  		goto out;
>  	}