From nobody Mon Jun 9 12:09:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bG9jG4FVsz5y2fT; Mon, 09 Jun 2025 12:10:10 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bG9jF6YgPz3hPK; Mon, 09 Jun 2025 12:10:09 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 559C9tLb089335; Mon, 9 Jun 2025 15:09:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 559C9tLb089335 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 559C9t1G089334; Mon, 9 Jun 2025 15:09:55 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 9 Jun 2025 15:09:55 +0300 From: Konstantin Belousov To: Rick Macklem Cc: Dag-Erling =?utf-8?B?U23DuHJncmF2?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 79d0f4474653 - main - rpcbind: Ensure krpc is present. Message-ID: References: <202506091053.559ArJ8k043104@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Result: default: False [1.65 / 15.00]; NEURAL_SPAM_LONG(1.00)[1.000]; NEURAL_SPAM_MEDIUM(1.00)[0.997]; NEURAL_HAM_SHORT(-0.35)[-0.350]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; HAS_XAW(0.00)[] X-Rspamd-Queue-Id: 4bG9jF6YgPz3hPK X-Spamd-Bar: + On Mon, Jun 09, 2025 at 04:59:15AM -0700, Rick Macklem wrote: > On Mon, Jun 9, 2025 at 4:49 AM Konstantin Belousov wrote: > > > > CAUTION: This email originated from outside of the University of Guelph. Do not click links or open attachments unless you recognize the sender and know the content is safe. If in doubt, forward suspicious emails to IThelp@uoguelph.ca. > > > > On Mon, Jun 09, 2025 at 10:53:19AM +0000, Dag-Erling Smørgrav wrote: > > > The branch main has been updated by des: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=79d0f447465394fee8afa833dbdeb1a5f3ed52c3 > > > > > > commit 79d0f447465394fee8afa833dbdeb1a5f3ed52c3 > > > Author: Dag-Erling Smørgrav > > > AuthorDate: 2025-06-09 10:52:21 +0000 > > > Commit: Dag-Erling Smørgrav > > > CommitDate: 2025-06-09 10:52:21 +0000 > > > > > > rpcbind: Ensure krpc is present. > > > > > > MFC after: 1 week > > > Reviewed by: rmacklem, glebius > > > Differential Revision: https://reviews.freebsd.org/D50627 > > > --- > > > usr.sbin/rpcbind/rpcbind.c | 35 +++++++++++++++++++++-------------- > > > 1 file changed, 21 insertions(+), 14 deletions(-) > > > > > > diff --git a/usr.sbin/rpcbind/rpcbind.c b/usr.sbin/rpcbind/rpcbind.c > > > index 1397a0222396..622e954f903b 100644 > > > --- a/usr.sbin/rpcbind/rpcbind.c > > > +++ b/usr.sbin/rpcbind/rpcbind.c > > > @@ -39,34 +39,38 @@ > > > * > > > */ > > > > > > -#include > > > -#include > > > -#include > > > -#include > > > +#include > > > +#include > > > +#include > > > #include > > > -#include > > > #include > > > #include > > > +#include > > > +#include > > > #include > > > +#include > > > + > > > #include > > > #include > > > #ifdef PORTMAP > > > #include > > > #endif > > > #include > > > + > > > #include > > > +#include > > > +#include > > > #include > > > +#include > > > #include > > > +#include > > > #include > > > #include > > > -#include > > > #include > > > -#include > > > -#include > > > -#include > > > -#include > > > #include > > > -#include > > > +#include > > > +#include > > > + > > > #include "rpcbind.h" > > > > > > /* Global variables */ > > > @@ -148,12 +152,15 @@ main(int argc, char *argv[]) > > > > > > update_bound_sa(); > > > > > > + /* Ensure krpc is loaded */ > > > + if (modfind("krpc") < 0 && kldload("krpc") < 0) > > > + err(1, "krpc"); > > Why does rpcbind need krpc mod? > > I understand that today most uses of Sun RPC are coming from nfs stuff. > > But it is still not the only application. E.g., NIS is still there. > > I asked the same thig during review. It appears that the requirement > is based on the recent change to using RPC over netlink instead > of a unix domain socket, done by glebius@. For what? Take for instance a machine participating in NIS domain but not doing NFS.