From owner-freebsd-bugs@FreeBSD.ORG Tue Sep 13 11:26:58 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CD8E16A41F; Tue, 13 Sep 2005 11:26:58 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1AFB43D45; Tue, 13 Sep 2005 11:26:57 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from freefall.freebsd.org (rwatson@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j8DBQvjw016768; Tue, 13 Sep 2005 11:26:57 GMT (envelope-from rwatson@freefall.freebsd.org) Received: (from rwatson@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j8DBQvkL016764; Tue, 13 Sep 2005 11:26:57 GMT (envelope-from rwatson) Date: Tue, 13 Sep 2005 11:26:57 GMT From: Robert Watson Message-Id: <200509131126.j8DBQvkL016764@freefall.freebsd.org> To: Guido.Laubner@gmx.de, rwatson@FreeBSD.org, freebsd-bugs@FreeBSD.org Cc: Subject: Re: kern/65786: [vfs_syscalls.c] Incorrect fifo semantics X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 11:26:58 -0000 Synopsis: [vfs_syscalls.c] Incorrect fifo semantics State-Changed-From-To: open->patched State-Changed-By: rwatson State-Changed-When: Tue Sep 13 11:24:53 GMT 2005 State-Changed-Why: I independently bumped into this bug while investigating a race condition in fifos, and drew the same conclusion as Bruce: POSIX specifies that ESPIPE should be returned on lseek() attempts. This has been patched as fifofs_vnops.c:1.119 in 7.x-CURRENT, and will be merged to other branches after additional testing time has passed. The commit information: revision 1.119 date: 2005/09/12 12:15:12; author: rwatson; state: Exp; lines: +1 -1 Remove DFLAG_SEEKABLE from fifo file descriptors: fifos are not seekable according to POSIX, not to mention the fact that it doesn't make sense (and hence isn't really implemented). This causes the fifo_misc regression test to succeed. I'm leaving this PR in the patched state until the fix is merged to appropriate branches. http://www.freebsd.org/cgi/query-pr.cgi?pr=65786