From owner-cvs-all@FreeBSD.ORG Tue May 22 00:37:58 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0729D16A400; Tue, 22 May 2007 00:37:58 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id E7E3713C457; Tue, 22 May 2007 00:37:57 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 6F7431A4D83; Mon, 21 May 2007 17:38:56 -0700 (PDT) Date: Mon, 21 May 2007 17:38:56 -0700 From: Alfred Perlstein To: Andre Oppermann Message-ID: <20070522003856.GX21795@elvis.mu.org> References: <200705192051.l4JKp0rF074703@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705192051.l4JKp0rF074703@repoman.freebsd.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2007 00:37:58 -0000 Is this the same bug that used to be in sendfile but got corrected some years back? * Andre Oppermann [070519 13:52] wrote: > andre 2007-05-19 20:50:59 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_syscalls.c > Log: > In kern_sendfile() adjust byte accounting of the file sending loop to > ignore the size of any headers that were passed with the sendfile(2) > system call. Otherwise the file sent will be truncated by the header > size if the nbytes parameter was provided. The bug doesn't show up > when either nbytes is zero, meaning send the whole file, or no header > iovec is provided. > > Resolve a potential error aliasing of errors from the VM and sf_buf > parts and the protocol send parts where an error of the latter over- > writes one of the former. > > Update comments. > > The byte accounting bug wasn't seen in earlier because none of the popular > sendfile(2) consumers, Apache, lighttpd and our ftpd(8) use it in modes > that trigger it. The varnish HTTP proxy makes full use of it and exposed > the problem. > > Bug found by: phk > Tested by: phk > > Revision Changes Path > 1.256 +37 -13 src/sys/kern/uipc_syscalls.c -- - Alfred Perlstein