From owner-freebsd-acpi@FreeBSD.ORG Thu Jan 8 10:30:22 2015 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3660B46E; Thu, 8 Jan 2015 10:30:22 +0000 (UTC) Received: from sola.nimnet.asn.au (paqi.nimnet.asn.au [115.70.110.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7CEC3AE2; Thu, 8 Jan 2015 10:30:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by sola.nimnet.asn.au (8.14.2/8.14.2) with ESMTP id t08AUAEF009361; Thu, 8 Jan 2015 21:30:10 +1100 (EST) (envelope-from smithi@nimnet.asn.au) Date: Thu, 8 Jan 2015 21:30:10 +1100 (EST) From: Ian Smith To: Juris Kaminskis Subject: Re: [Bug 162859] [acpi] ACPI battery/acline monitoring partialy working (switching) In-Reply-To: Message-ID: <20150108205333.B82172@sola.nimnet.asn.au> References: <20150104234107.Q82172@sola.nimnet.asn.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: freebsd-acpi@freebsd.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jan 2015 10:30:22 -0000 On Wed, 7 Jan 2015 20:23:51 +0200, Juris Kaminskis wrote: > 2015-01-05 17:27 GMT+02:00 Juris Kaminskis : > > 2015-01-04 15:17 GMT+02:00 Ian Smith : > > > > > > On Sat, 3 Jan 2015 11:45:05 +0000, bugzilla-noreply@freebsd.org wrote: > > > > > > Please excuse this off-'zilla merely speculative response. No time, but > > > I've spent (wasted?) some time chasing a couple of these outside the PR. > > > > > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=162859 > > > > > > > > --- Comment #14 from juris --- > > > > Problem on /head/ branch is introduced with revision 216942. > > > > > > If true (in all cases) this is great news for those with a variety of HP > > > laptops that have been experiencing partial - or in some cases complete > > > after boot - failures in CMBAT monitoring since 9.0. And a Macbook Pro. > > > > > > So, reverting rev 216942 fixes it for you? On what FreeBSD version? > > > > I have compiled head branch revision 216941 and battery status via > > acpiconf works. When compiling from source revision 216942 acpiconf stops > > responding. I also tried to remove r216942 and compiled from source release > > 9.3, but there battery status was not working. Apparently there are more > > things than just one that breaks HP ACPI . > Sorry for my previous email that was confusing. I did not revert r216941 > when compiled release 9.3. So when I did that, battery status works. I also > compiled release 10.1 with excluding r216942, and battery status works. So > this single change for some reason creates problem for HP laptops. So it seems; I'll post a proper response based on the text above and my musings below to bugzilla .. such details are important, and I should have been game to speculate there originally, my apologies to all. It's important to note that this PR was originally filed on 2011-11-24 21:50 UTC by msuszko, at version 9.0-PRERELEASE. revision 216942 was committed to head on Jan 4 00:10:29 2011 UTC (4 years ago) by jkim, while head was 9-CURRENT, and hasn't changed since. It seems fortunate, for HP laptops anyway, that this was not apparently merged back to 8.x. cheers, Ian > > > If so, with scant comprehension of the code, questions that occur: > > > > > > a) did that revision fix some existing problem, the reverting of which > > > might reestablish problem/s in other machines? jkim? > > > > > > b) what is it in various HP ACPI implementations that don't seem to be a > > > reported problem on other hardware, particularly concerning EC handling? > > > > > > c) if this was wrong (for HPs), what would be right? (the hard one :) > > > > > > cheers, Ian