From owner-freebsd-audit Fri Jul 12 1: 0:17 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0BFC37B400; Fri, 12 Jul 2002 01:00:13 -0700 (PDT) Received: from melusine.cuivre.fr.eu.org (melusine.cuivre.fr.eu.org [62.212.105.185]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14EC443E64; Fri, 12 Jul 2002 01:00:13 -0700 (PDT) (envelope-from thomas@cuivre.fr.eu.org) Received: by melusine.cuivre.fr.eu.org (Postfix, from userid 1000) id 413C12C3D4; Fri, 12 Jul 2002 10:00:10 +0200 (CEST) Date: Fri, 12 Jul 2002 10:00:10 +0200 From: Thomas Quinot To: Alfred Perlstein Cc: bde@freebsd.org, audit@freebsd.org Subject: Re: trpt cleanup Message-ID: <20020712100010.B50744@melusine.cuivre.fr.eu.org> Reply-To: thomas@cuivre.fr.eu.org References: <20020711224521.GD97638@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5i In-Reply-To: <20020711224521.GD97638@elvis.mu.org>; from bright@mu.org on Thu, Jul 11, 2002 at 03:45:21PM -0700 X-message-flag: WARNING! Using Outlook can damage your computer. Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Le 2002-07-12, Alfred Perlstein écrivait : > -struct nlist nl[] = { > +struct nlist nl[3]; > #define N_TCP_DEBUG 0 > - { "_tcp_debug" }, > #define N_TCP_DEBX 1 > - { "_tcp_debx" }, > - { "" }, > -}; This change, and the corresponding initialization added to main(), is questionable. Having an explicit element count, rather than an initializer, for nl means that the information of many elements there are in nl is sprinkled all over the place (here where nl is declared, and then also at the place where the array is initialized), and that both places need to be kept consistent by hand. Keeping things consistent is a job that compilers do very well, but that programmers tend to botch from time to time: better leave it to the compiler. Thomas. -- Thomas.Quinot@Cuivre.FR.EU.ORG To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message