From owner-freebsd-bugs@freebsd.org  Sat Jan 21 02:43:11 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4792ECBA770
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Sat, 21 Jan 2017 02:43:11 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 373761E03
 for <freebsd-bugs@FreeBSD.org>; Sat, 21 Jan 2017 02:43:11 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0L2hAh9052738
 for <freebsd-bugs@FreeBSD.org>; Sat, 21 Jan 2017 02:43:11 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 195763] bsdgrep, empty matches and -o
Date: Sat, 21 Jan 2017 02:43:10 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 10.1-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: bsdports@kyle-evans.net
X-Bugzilla-Status: Open
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created
Message-ID: <bug-195763-8-uyan2VmiNQ@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-195763-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-195763-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jan 2017 02:43:11 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D195763

Kyle Evans <bsdports@kyle-evans.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #179126|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle Evans <bsdports@kyle-evans.net> ---
Created attachment 179171
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179171&action=
=3Dedit
Proposed patch to address line matching issues

emaste@ - I believe this to be my final iteration of this patch. Because th=
is
and bug #209116 are both somewhat major issues with procline(), this patch
addresses both PRs and obsoletes both previous patches.

I've added to printline() a bail-out if -o and matchall (empty pattern) are=
 set
-- this coincides with GNU grep's behavior.

Assuming I ran the tests correctly (make && make install && kyua test -k
/usr/tests/usr.bin/grep/Kyuafile), I haven't yet introduced any regressions
there. One of my next steps might be to review the unit test coverage and m=
ake
sure it's sufficient, though, since it was passing before despite having all
kinds of problems.

--=20
You are receiving this mail because:
You are the assignee for the bug.=