From nobody Thu Apr 4 19:17:52 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V9Wbn0XVjz5Fqrb; Thu, 4 Apr 2024 19:17:57 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4V9Wbm1xb6z40XW; Thu, 4 Apr 2024 19:17:55 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1712258273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A83OHuFVBWeLvmLJkv2Z2rhv/kjdXnBY+FKMfkDsmdY=; b=GfSyLkAu/3IuyAWOpIxTtpaMVZKQvOC6x5NACQ6S2N7Dlr00POWk+R8lw2QFFzIF8ijitw 1Uze2Cs/UClTiU4+INgy7gA0A1fgkESqgdgDz++9ulvq/tPoYtU/rvwyajkSf3skXO+jhx 42MrHSNol1biSzPjP6cGlgf5G0pyVfk= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 631c5fa9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 4 Apr 2024 19:17:53 +0000 (UTC) Date: Thu, 4 Apr 2024 21:17:52 +0200 From: Emmanuel Vadot To: Jan Beich Cc: Baptiste Daroussin , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Subject: Re: git: 77f72c463b90 - 2024Q1 - x11-servers/xwayland-devel: backport recent secfixes Message-Id: <20240404211752.63f24eade7958ef662aa78ec@bidouilliste.com> In-Reply-To: <4jch-t3ly-wny@FreeBSD.org> References: <202404040955.4349tDrM089062@gitrepo.freebsd.org> <20240404125743.1e52876a69053b726cb456e4@bidouilliste.com> <8r1t-ny0j-wny@FreeBSD.org> <20240404141239.35d54535539b66cd6336ee5b@bidouilliste.com> <7chd-l2ru-wny@FreeBSD.org> <20240404151554.04340786db8562e522f7b1a8@bidouilliste.com> <8r1t-chhu-wny@FreeBSD.org> <20240404174208.2eaefae74933715eeb31ccbc@bidouilliste.com> <4jch-t3ly-wny@FreeBSD.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Queue-Id: 4V9Wbm1xb6z40XW On Thu, 04 Apr 2024 19:55:05 +0200 Jan Beich wrote: > Emmanuel Vadot writes: > > > On Thu, 04 Apr 2024 16:47:09 +0200 > > Jan Beich wrote: > > > >> Baptiste Daroussin writes: > >> > >> > On Thu 04 Apr 15:48, Jan Beich wrote: > >> > > >> >> Emmanuel Vadot writes: > >> >> > >> >> >> but also introduced a number of regressions that > >> >> >> don't exist in my port, all of which were documented in my reviews. > >> >> > > >> >> > What regressions ? I'm using xwayland for more than a year on my > >> >> > desktop instead of -devel and haven't seen a problem. > >> >> > >> >> Try diff xwayland{,-devel}/Makefile: > >> >> - Missing XSECURITY (ssh -X vs. ssh -Y; xorg-server parity per bug 221984) > >> >> - Missing XDMCP (xorg-server parity, maybe used with rootful Xwayland and GUI login managers) > >> >> - Missing XTEST input emulation (XDG Portal API, required by GNOME, Plasma and maybe rootful Xwayland) > >> >> - Missing CSD for rootful (mainly for GNOME, optional even if preferred elsewhere) > > > > All those options could be added. The main reason that they are not is > > that x11-server/xwayland isn't used by anyone but me as it requires > > patching ports to use it. So obviously if they aren't needed for my > > case no one will stand up and ask for them to be enabled. > > Another way to view this is that you enabled all those options without > > consulting anyone, why would you you might ask, it's your port ? Well > > yes but since this port is forced to be used by everyone enabling > > option and dependencies should be a concensus between multiple users. > > For some, (like XSECURITY) you've explained in the commit message so > > that's good at least. Other like CSD was enabled without anything in > > the commit message except that this was an update, this is not good. > > - XDMCP was enabled (auto-detection) in xwayland up until 5f87249229d3 > - xwayland-devel was created before 5f87249229d3 thus used xwayland and > xorg-server from back then as the reference for feature defaults > - CSD and EI are enabled due upstream default (auto-detection) and > as part of "batteries included" policy for binary packages > > >> >> - Broken on DragonFly due to forcing -Dsha1 (already default after I've fixed upstream bug years ago) > > > > I don't care about Dragonfly, they are grown ups and can manage their > > own ports. > > Sure but the option is redundant on FreeBSD. libmd is already preferred > and auto-detected over OpenSSL, nettle or gcrypt. > > > Lol, very bold of you to say this as all your ports forced on others > > follow your views. > > Sure but the proposal is no different. Under the guise of changing to a > stable version of dependency you also want to change maintainership into > one that benefits you. For example, all these x11@ updates you land > haven't been submitted through Bugzilla for peer review. You're absolutely right about my x11@ updates. Truth is I've started to put everything on phab when I took over (not willingly) x11@ and got tired that no one was reviewing patches. Now I'm alone on x11@ and no one seems to care to step up and help. Three or four years ago when I started to do x11@ stuff I've asked for your help and at this time you refused. Now I'm asking you again, if you want to join x11@ so we can combine our forces I would be more than happy. I really believe that the force of FreeBSD is it's community and doing things alone is never a good thing, I have plan to change that and I would prefer that it will include you. > > I think that you should fork the ports tree to JanPorts, do your stuff > > there and for the FreeBSD ports tree please start engaging discussion > > with the community, you are not alone. > > Bug 244016 is an example discussion. Looks civil? Sure do, but what I get from this PR is that we switch kde to xwayland-devel because of no good reason. The only "good" one was that users couldn't install kde and sway in // because sway was bringing -devel and kde wasn't. This is the worst reason to switch a port to a -devel version dep. > Now look at bug 276614. I am very familiar with this one, I was probably not civil on it, not sure if I was the least civil person. > Many years have passed but I see x11@ culture of brandishing authority > hasn't disappeared. We need guidelines, this is the thing that FreeBSD needs the most and have the least IMHO. Cheers, -- Emmanuel Vadot