From owner-freebsd-hackers@FreeBSD.ORG  Sun Sep  2 22:12:02 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6B01F1065670;
	Sun,  2 Sep 2012 22:12:02 +0000 (UTC)
	(envelope-from yanegomi@gmail.com)
Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com
	[209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 1903A8FC1C;
	Sun,  2 Sep 2012 22:12:02 +0000 (UTC)
Received: by obbun3 with SMTP id un3so10830744obb.13
	for <multiple recipients>; Sun, 02 Sep 2012 15:12:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=mJ6jtGrB9EaMEKCGyMhYAYJz5qLLOtdNelLSXKkpeuY=;
	b=J447595kduDClFl+k7HMDF/lefBr5ASmGPi/vskB5u5s6PMeXeUUHpxb6uSQbUb4Un
	vXa5njOuDoTLJ90DYBivtbYO5fXIsyYt7ooP0EhXQHxT3+zH8RU+HNe56rc664dKXW+t
	MZYww4zMghSwPdJWUOkwl7u5cMAwFe3WOQOJIgpsld9DjDf5KvYg/cgEPhEihkRrFd2T
	Gb6ZFwT8B1QEphDZ1INa6bMB9d8ZEg/T0L4njy9qT2cgtc7etKGV51Pb29hbGI3P+/t2
	ppDPkN9Prep7Zr9PsY8q+h5ffGhX469XYU7hu94A4ly7QksCmvGdOwxPCE/n/LPu92Yo
	2S6A==
MIME-Version: 1.0
Received: by 10.60.171.69 with SMTP id as5mr12902617oec.100.1346623921679;
	Sun, 02 Sep 2012 15:12:01 -0700 (PDT)
Received: by 10.76.142.201 with HTTP; Sun, 2 Sep 2012 15:12:01 -0700 (PDT)
In-Reply-To: <CAGH67wQpgdqnXSeRUnUACQHNWJi-Z9ZEsB6ZQZ7Bf_W2nXyUKg@mail.gmail.com>
References: <20120902214616.GB1507@glenbarber.us>
	<CAGH67wQpgdqnXSeRUnUACQHNWJi-Z9ZEsB6ZQZ7Bf_W2nXyUKg@mail.gmail.com>
Date: Sun, 2 Sep 2012 15:12:01 -0700
Message-ID: <CAGH67wSEhTqDft7C9VZy4h82xrkjjq7w9Y+-apynUMK4Pwycsg@mail.gmail.com>
From: Garrett Cooper <yanegomi@gmail.com>
To: Glen Barber <gjb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: hackers@freebsd.org
Subject: Re: [PATCH] head/Makefile.inc1: Fix 'make distributeworld' when
 defining WITHOUT_GAMES
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Sep 2012 22:12:02 -0000

On Sun, Sep 2, 2012 at 3:05 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
> On Sun, Sep 2, 2012 at 2:46 PM, Glen Barber <gjb@freebsd.org> wrote:
>> Hi,
>>
>> Attached patch fixes 'make distributeworld' and our 'make release'
>> scripts when WITHOUT_GAMES is set.
>>
>> Can someone please comment/test/commit?
>
>     It should be `.if ${MK_GAMES} != "no"`. Other than that, LGTM!

    I would also dare to go one step further and remove
`${WORLDTMP}/legacy/usr/games` from BPATH and XPATH when ${MK_GAMES}
== "no" to reduce the number of path lookups done (this should help
speed up the build a bit).
Thanks!
-Garrett