From owner-cvs-src@FreeBSD.ORG Wed Oct 29 11:15:01 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9172716A4CE; Wed, 29 Oct 2003 11:15:01 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F48443FE9; Wed, 29 Oct 2003 11:15:01 -0800 (PST) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h9TJF0XJ043866; Wed, 29 Oct 2003 11:15:00 -0800 (PST) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h9TJF0ff043865; Wed, 29 Oct 2003 11:15:00 -0800 (PST) (envelope-from sam) Message-Id: <200310291915.h9TJF0ff043865@repoman.freebsd.org> From: Sam Leffler Date: Wed, 29 Oct 2003 11:15:00 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_mroute.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Oct 2003 19:15:01 -0000 sam 2003/10/29 11:15:00 PST FreeBSD src repository Modified files: sys/netinet ip_mroute.c Log: Potential fix for races shutting down callouts when unloading the module. Previously we grabbed the mutex used by the callouts, then stopped the callout with callout_stop, but if the callout was already active and blocked by the mutex then it would continue later and reference the mutex after it was destroyed. Instead stop the callout first then lock. Supported by: FreeBSD Foundation Revision Changes Path 1.94 +6 -2 src/sys/netinet/ip_mroute.c