From owner-freebsd-hackers Wed Sep 20 22:23:26 1995 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id WAA24393 for hackers-outgoing; Wed, 20 Sep 1995 22:23:26 -0700 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id WAA24384 for ; Wed, 20 Sep 1995 22:23:18 -0700 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id PAA29492 for freebsd-hackers@freebsd.org; Thu, 21 Sep 1995 15:22:03 +1000 Date: Thu, 21 Sep 1995 15:22:03 +1000 From: Bruce Evans Message-Id: <199509210522.PAA29492@godzilla.zeta.org.au> To: freebsd-hackers@freebsd.org Subject: Re: xntpd (or kernel) timekeeping problem? Sender: owner-hackers@freebsd.org Precedence: bulk >> >TIMER_FREQ should once and forever be banned from all source files and >> >moved out into a header file. (isa.h?) >>... >Who's volunteering? I think you need an agrep to find all the >locations where this frequency has been defined throughout the source >tree. Note that the several definitions used to differ slightly. :-) pcvt spells it PCVT_SYSBEEPF but gives it the same value. This doesn't annoy me as much as both syscons and pcvt ignoring the keyboard defines that were already in a header files (ic/i8042.h). E.g., port ic/i8042.h ../include/console.h pcvt/pcvt_hdr.h ---- ---------- -------------------- --------------- 0x60 KBDATAP, KBOUTP KB_DATA, KB_WRITE CONTROLLER_DATA 0x64 KBSTATP KB_STAT CONTROLLER_CTRL state ic/i8042.h ../include/console.h pcvt/pcvt_hdr.h ----- ---------- -------------------- --------------- 0x01 KBS_DIB KB_BUF_FULL STATUS_OUTPBF 0x02 KBS_IBF KB_READY STATUS_INPBF not to mention port isa.h GENERIC LINT thousands of config files ---- ----- ------- ---- ------------------------- 0x60 IO_KBD IO_KBD IO_KBD IO_KBD The value in the config files is ignored. Bruce