From owner-freebsd-stable@FreeBSD.ORG  Sun Jan 12 12:18:09 2014
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6849F68A;
 Sun, 12 Jan 2014 12:18:09 +0000 (UTC)
Received: from mail-ee0-x22e.google.com (mail-ee0-x22e.google.com
 [IPv6:2a00:1450:4013:c00::22e])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A64121D69;
 Sun, 12 Jan 2014 12:18:08 +0000 (UTC)
Received: by mail-ee0-f46.google.com with SMTP id d49so2666747eek.19
 for <multiple recipients>; Sun, 12 Jan 2014 04:18:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=Uex8Ol1HGCCIMihQFtUYiZYspCZdj4vmfw5hwOTexJk=;
 b=BHAF82GG6+suKoipn3aBNN0UK2mhGJkNkNp3JkZ9u/WhTHztg19eS1Rgb0kfn991PF
 nKz70YknqKBwt10WWL42VbRZy4t87k2KHBKd21Le6lz1tCkpYuWuiQoVxop1dpgsRq3S
 /NQCj23l2p4RwoXBMsTJleqUpgA/POuFN7o3TIFkmBzGdxYIDYf7XgiLFXCpdEcSrfWJ
 OHJOa/P4SWws2ErbMKcHMeSlyNZgigJG2S/7uczQQIZFOOowXKY0efPtuqU8jRuBWjAK
 p92dchfD8yBWQAHagOdRcwady2TEfgqDBiu7aQUswXYJW2h5VhQ74yYZwZ4b+yfhujLS
 3r+w==
X-Received: by 10.15.75.68 with SMTP id k44mr21357047eey.57.1389529086985;
 Sun, 12 Jan 2014 04:18:06 -0800 (PST)
Received: from localhost ([178.150.115.244])
 by mx.google.com with ESMTPSA id m48sm12575268eef.6.2014.01.12.04.18.05
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 12 Jan 2014 04:18:06 -0800 (PST)
Sender: Mikolaj Golub <to.my.trociny@gmail.com>
Date: Sun, 12 Jan 2014 14:18:03 +0200
From: Mikolaj Golub <trociny@FreeBSD.org>
To: Devin Teske <dteske@freebsd.org>
Subject: Re: MFC r258588: Fix for VIMAGE
Message-ID: <20140112121802.GA16750@gmail.com>
References: <4BDBE950-849D-4FBF-9F62-F08200A22F15@fisglobal.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BDBE950-849D-4FBF-9F62-F08200A22F15@fisglobal.com>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: Craig Rodrigues <rodrigc@freebsd.org>, freebsd-stable@freebsd.org, "Teske,
 Devin" <Devin.Teske@fisglobal.com>
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Jan 2014 12:18:09 -0000

On Tue, Dec 31, 2013 at 12:12:47AM +0000, Teske, Devin wrote:
> Hi,
> 
> I recently updated from 9.2-R to stable/9 and found that many times while
> attempting to shut down a vimage jail, that the box would crash. So I found
> SVN r258588 in HEAD, merged it into my stable/9 kernel, rebooted.. and
> problem is now solved.
> 
> Any objects to merging r258588 to stable/9?

Ah, it looks like I was responsible for that bug. Craig, thank you for
fixing it. I think it should definitely be merged to stable/9.

BTW, wouldn't increasing IPFW_NAT_VNET_ORDER instead of
IPFW_NAT_SI_SUB_FIREWALL fix the issue? It looks a little better to me.
Also, I think it would be good to have some coment in the code why
this order was chosen. Or better -- to export startup order
declarations from ip_fw2.c to ip_fw_private.h and use it for ip_fw_nat
too, so it would become self-documenting and not break if one decides
to change the ordering in ipfw module.

-- 
Mikolaj Golub