From owner-freebsd-current@FreeBSD.ORG  Thu May 10 10:03:53 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2906E1065675;
	Thu, 10 May 2012 10:03:53 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
	[IPv6:2001:7b8:2ff:146::2])
	by mx1.freebsd.org (Postfix) with ESMTP id DA1738FC16;
	Thu, 10 May 2012 10:03:52 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:4e8:581c:149b:809b] (unknown
	[IPv6:2001:7b8:3a7:0:4e8:581c:149b:809b])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id 5B0F05C37;
	Thu, 10 May 2012 12:03:50 +0200 (CEST)
Message-ID: <4FAB9289.8060808@FreeBSD.org>
Date: Thu, 10 May 2012 12:03:53 +0200
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:13.0) Gecko/20120425 Thunderbird/13.0
MIME-Version: 1.0
To: Kohji Okuno <okuno.kohji@jp.panasonic.com>
References: <20120510.180247.93202495593231609.okuno.kohji@jp.panasonic.com>
In-Reply-To: <20120510.180247.93202495593231609.okuno.kohji@jp.panasonic.com>
X-Enigmail-Version: 1.5a1pre
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org, David Chisnall <theraven@FreeBSD.org>
Subject: Re: The current libc/locale/toupper.c is mistaken
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 May 2012 10:03:53 -0000

On 2012-05-10 11:02, Kohji Okuno wrote:
> I think that libc/locale/toupper.c is mistaken.
> Could you check it?
> 
> @@ -51,7 +51,7 @@ ___toupper_l(c, l)
>  {
>         size_t lim;
>         FIX_LOCALE(l);
> -       _RuneRange *rr = &XLOCALE_CTYPE(l)->runes->__maplower_ext;
> +       _RuneRange *rr = &XLOCALE_CTYPE(l)->runes->__mapupper_ext;
>         _RuneEntry *base, *re;
>  
>         if (c < 0 || c == EOF)

Yes, this definitely looks like a copy/paste error, introduced here:

http://svnweb.freebsd.org/base/head/lib/libc/locale/toupper.c?r1=165903&r2=227753

I'll commit the fix tonight (CEST), if David isn't faster than me. :)

Thanks!