From owner-cvs-src-old@FreeBSD.ORG  Thu Nov  4 21:10:39 2010
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 71EE0106564A
	for <cvs-src-old@freebsd.org>; Thu,  4 Nov 2010 21:10:39 +0000 (UTC)
	(envelope-from kib@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 452D48FC14
	for <cvs-src-old@freebsd.org>; Thu,  4 Nov 2010 21:10:39 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id oA4LAd2n021619
	for <cvs-src-old@freebsd.org>; Thu, 4 Nov 2010 21:10:39 GMT
	(envelope-from kib@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.4/8.14.4/Submit) id oA4LAd3m021618
	for cvs-src-old@freebsd.org; Thu, 4 Nov 2010 21:10:39 GMT
	(envelope-from kib@repoman.freebsd.org)
Message-Id: <201011042110.oA4LAd3m021618@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	kib@repoman.freebsd.org using -f
From: Konstantin Belousov <kib@FreeBSD.org>
Date: Thu, 4 Nov 2010 09:29:00 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/libexec/rtld-elf rtld.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Nov 2010 21:10:39 -0000

kib         2010-11-04 09:29:00 UTC

  FreeBSD src repository

  Modified files:
    libexec/rtld-elf     rtld.c 
  Log:
  SVN rev 214777 on 2010-11-04 09:29:00Z by kib
  
  In r214728, if dlopen() is called for the object that has been already
  loaded as a dependency and marked -z nodlopen, object' DAG is already
  initialized by load_needed_objects(). Due to this, the init_dag() call
  from dlopen() does not increment refcount for the object [1].
  
  Change init_dag() to not increment DAG refcount. Require explicit calls
  to ref_dag() to increment, and assert that ref_dag() and unref_dag()
  are called for root that has dag initialized. To fix the noted issue,
  unconditionally call both init_dag() and ref_dag() in dlopen() for the
  case when the object was already loaded, making it similar to the case
  of newly loaded object.
  
  Noted by:       jh [1]
  Reviewed by:    jh, kan
  MFC after:      6 days
  
  Revision  Changes    Path
  1.160     +5 -5      src/libexec/rtld-elf/rtld.c