From owner-cvs-sys Tue Aug 1 22:34:12 1995 Return-Path: cvs-sys-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.11/8.6.6) id WAA11716 for cvs-sys-outgoing; Tue, 1 Aug 1995 22:34:12 -0700 Received: from sequent.kiae.su (sequent.kiae.su [144.206.136.6]) by freefall.cdrom.com (8.6.11/8.6.6) with SMTP id WAA11680 ; Tue, 1 Aug 1995 22:33:57 -0700 Received: by sequent.kiae.su id AA01116 (5.65.kiae-2 ); Wed, 2 Aug 1995 09:30:41 +0400 Received: by sequent.KIAE.su (UUMAIL/2.0); Wed, 2 Aug 95 09:30:40 +0400 Received: (from ache@localhost) by astral.msk.su (8.6.8/8.6.6) id JAA00364; Wed, 2 Aug 1995 09:22:39 +0400 To: CVS-commiters@freefall.cdrom.com, Bruce Evans , cvs-sys@freefall.cdrom.com References: <199508020008.KAA09830@godzilla.zeta.org.au> In-Reply-To: <199508020008.KAA09830@godzilla.zeta.org.au>; from Bruce Evans at Wed, 2 Aug 1995 10:08:12 +1000 Message-Id: Organization: Olahm Ha-Yetzirah Date: Wed, 2 Aug 1995 09:22:39 +0400 (MSD) X-Mailer: Mail/@ [v2.40 FreeBSD] From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= aka "Andrey A. Chernov, Black Mage" X-Class: Fast Subject: Re: cvs commit: src/sys/kern tty.c tty_compat.c Lines: 27 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Length: 1067 Sender: cvs-sys-owner@freebsd.org Precedence: bulk In message <199508020008.KAA09830@godzilla.zeta.org.au> Bruce Evans writes: >> Modified: sys/kern tty.c tty_compat.c >> Log: >> Check for valid speeds in TIOCSET* and return EINVAL for incorrect >> values instead of setting garbadge. >All speeds between 1 and LONG_MAX are valid. Some drivers support 0 here >setting speeds that can't be handled by tty_compat. E.g., the cy >driver allows 76800 and 150000 and many others. Handling these >is a problem for tty_compat and crufty applications, not for the >termios driver. Ok, I'll left only check for negative values in tty.c >All h/w tty drivers (except iitty :-() do their own speed checking. >Perhaps the pty driver should only allow the standard speeds. And move this checking into pty driver. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849