From owner-freebsd-ports@FreeBSD.ORG  Wed Dec 19 20:48:21 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3016E16A421
	for <freebsd-ports@freebsd.org>; Wed, 19 Dec 2007 20:48:21 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.60.158])
	by mx1.freebsd.org (Postfix) with ESMTP id 1AB9713C458
	for <freebsd-ports@freebsd.org>; Wed, 19 Dec 2007 20:48:20 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: by syn.atarininja.org (Postfix, from userid 1001)
	id 3F4855C2E; Wed, 19 Dec 2007 15:53:40 -0500 (EST)
Date: Wed, 19 Dec 2007 15:53:40 -0500
From: Wesley Shields <wxs@atarininja.org>
To: RW <fbsd06@mlists.homeunix.com>
Message-ID: <20071219205340.GD36016@atarininja.org>
References: <4D1AAAB26DADCFB11343F6B3@utd59514.utdallas.edu>
	<47693FE9.20701@gahr.ch>
	<41364CD63DE952CCB8602A44@utd59514.utdallas.edu>
	<20071219191306.GC36016@atarininja.org>
	<20071219201316.1c305f7a@gumby.homeunix.com.>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071219201316.1c305f7a@gumby.homeunix.com.>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: freebsd-ports@freebsd.org
Subject: Re: Optional patching
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2007 20:48:21 -0000

On Wed, Dec 19, 2007 at 08:13:16PM +0000, RW wrote:
> On Wed, 19 Dec 2007 14:13:06 -0500
> Wesley Shields <wxs@atarininja.org> wrote:
> 
> > I don't think it matters really, but is probably a matter of personal
> > preference.  The only problem with using an option that I see is that
> > if the user has no idea if (s)he is on a 64bit platform and turns the
> > option off.  It's for this reason I'd suggest using the .if ${ARCH}
> > approach.
> 
> I would have thought that the ".if ${ARCH}" method was the only
> sensible way of doing it. Packages are built without any options set.

They are built using the default OPTIONS in the Makefile - ie: those
that are specified as "on".  If what you say is true then one of my
ports would not build properly - it requires at least one of a few
options to be on.

Another reason not to put it in as an OPTION is that if the option
defaults to off the package will fail to build on 64bit platforms.

-- WXS