From owner-svn-ports-all@freebsd.org Fri Nov 8 09:53:43 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C30A51AD321; Fri, 8 Nov 2019 09:53:43 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 478bFM35l5z47p6; Fri, 8 Nov 2019 09:53:43 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 509534A2; Fri, 8 Nov 2019 04:53:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 08 Nov 2019 04:53:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=6fqTVv jEzmfNRDn1LCrhzQBwrdLhOS2Xot2Vnzv1xkQ=; b=yYHK1BBjLxiDs1FznkRqiX gikK8zW9rT+UwkV1N6wYODjIu0mtcRZJ/zKgJ3QZ8lZb9GXHlmKbq0zSRkyVTOJ9 aEaqlKlhm1GyWT1ZhOCpK5OEl1oR2YJF4he7DYUqEgFJqALN5ppOnhhTk7rgJJQ+ NsJgTGrAOHwZuwTId/AVSiStV47DrS13UwJDv1Kjaap6jxfc+lXl0xUAGHs4BvNa aomRyH/d7p/u27lovzpUkIMNBCSqYoxooN/WFZiQuxyNdDIxBsOXborSJlKXzsq6 rig3ML9tzZx//ihzovBq+ehJlGtU7Gu6rtFJLoWUgKCYZs+8G0NRY1/HvAWJRmDw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddvuddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesghdtreertdervdenucfhrhhomhepvfhosghi rghsucfmohhrthhkrghmphcuoehtohgsihhksehfrhgvvggsshgurdhorhhgqeenucffoh hmrghinhepfhhrvggvsghsugdrohhrghdpphhorhhtrdhmkhenucfkphepleehrdeltddr vddviedrfedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehtohgsihhksehfrhgvvggssh gurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from urd.tobik.me (ip5f5ae21e.dynamic.kabel-deutschland.de [95.90.226.30]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A30480062; Fri, 8 Nov 2019 04:53:39 -0500 (EST) Date: Fri, 8 Nov 2019 10:53:37 +0100 From: Tobias Kortkamp To: Niclas Zeising Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r516921 - head/Mk/Uses Message-ID: <20191108095337.GA69008@urd.tobik.me> References: <201911061902.xA6J2hV6031987@repo.freebsd.org> <20191108045247.GA82122@urd.tobik.me> <3f3eac2c-d705-c7dd-ccfd-a0ab5fef9c23@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline In-Reply-To: <3f3eac2c-d705-c7dd-ccfd-a0ab5fef9c23@freebsd.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 478bFM35l5z47p6 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.90 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.90)[-0.905,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; ASN(0.00)[asn:11403, ipnet:64.147.123.0/24, country:US] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2019 09:53:43 -0000 --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 08, 2019 at 10:42:15AM +0100, Niclas Zeising wrote: > On 2019-11-08 05:52, Tobias Kortkamp wrote: > > On Wed, Nov 06, 2019 at 07:02:43PM +0000, Niclas Zeising wrote: > >> Author: zeising > >> Date: Wed Nov 6 19:02:42 2019 > >> New Revision: 516921 > >> URL: https://svnweb.freebsd.org/changeset/ports/516921 > >> > >> Log: > >> Mk/Uses: Add USES+=3Dxorg when including xorg.mk > >> =20 > >> Add USES+=3Dxorg to the places where MK/Uses/xorg.mk is included fr= om other > >> files in the Uses infrastructure. This is done to silence an erron= eous > >> warning about USES=3Dxorg not being set when using USES=3Dgl, motif= or xorg-cat, > >> even when it's included from the framework. > >> =20 > >> This is a different proposal than what was originally suggested in = pr 241627 > >> and https://reviews.freebsd.org/D22210 . > >> =20 > >> PR: 238988, 241627 > >> Discussed with: mat > >> MFH: 2019Q4 > >> Differential Revision: https://reviews.freebsd.org/D22210 > >=20 > > Something is still wrong. A port with for example > >=20 > > USES=3D gl > > USE_GL=3D glut > >=20 > > will still give the bogus warning. It goes away with: > >=20 > > Index: Mk/Uses/gl.mk > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- Mk/Uses/gl.mk (revision 517030) > > +++ Mk/Uses/gl.mk (working copy) > > @@ -40,7 +40,9 @@ > > .if !defined(_GL_${_component}_LIB_DEPENDS) > > IGNORE=3D uses unknown GL component > > .else > > +.if defined(_GL_${_component}_USE_XORG) > > USE_XORG+=3D ${_GL_${_component}_USE_XORG} > > +.endif > > LIB_DEPENDS+=3D ${_GL_${_component}_LIB_DEPENDS} > > .endif > > .endfor > >=20 >=20 > Ok, I have to look into this as well, but your patch is probably good. > I wonder if this is still needed after the warnings in bsd.port.mk are=20 > removed (since I've tried to move everything to USES). > Do you have an example of a port that's an issue? Here are some ports that have this problem (might be behind non-default options): $ rg -l GL=3Dglut graphics/pfstools/Makefile [...] graphics/webp/Makefile [...] games/d2x/Makefile ^C --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl3FOxxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2HKGwf8D4SrtQfZ+sQzX+d/ReouIOInHD8rnCRFMhhSQPVQ8xmoc/HLOSIpSV4E 7UL15JKYW98cwmwuWmpFFTnr0IIqlNpnxavAga+ME6uhDZd8NbzJTaJrBKAPnLkH 2EM0ozNe+TKQU2nLNEf9g5wu6K6plenjbEg1MXI6EaUveYx5jplWGvEb9hUGpdTZ amPx49eZHLFWYIpZcY01dc8KEQ18IrUN54ppFnCVh5qlZqpmpZGKWw/Pinl0bdvO rnr1gHy67yY2rJJqXReAL1Gm8BGWtPY23pZ4byversi0Glu9Y+dl1Vvsg2tk9xVa /+HjQL5GS3Yv88WEjKJpIAaSzi2EuQ== =2VRY -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--