From owner-freebsd-current@FreeBSD.ORG Tue Jun 14 20:10:10 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2888116A41C; Tue, 14 Jun 2005 20:10:10 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A1C943D48; Tue, 14 Jun 2005 20:10:09 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received-SPF: pass (mp2.macomnet.net: domain of maxim@macomnet.ru designates 127.0.0.1 as permitted sender) receiver=mp2.macomnet.net; client_ip=127.0.0.1; envelope-from=maxim@macomnet.ru; Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.12.11/8.12.11) with ESMTP id j5EKA5sY076853; Wed, 15 Jun 2005 00:10:07 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Wed, 15 Jun 2005 00:10:05 +0400 (MSD) From: Maxim Konovalov To: "David O'Brien" In-Reply-To: <20050614190854.GA12928@dragon.NUXI.org> Message-ID: <20050614235132.L76669@mp2.macomnet.net> References: <20050613192308.GA87640@sandvine.com> <20050614082039.GA2038@dragon.NUXI.org> <20050614224704.Y75797@mp2.macomnet.net> <20050614190854.GA12928@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: freebsd-current@freebsd.org, Ed Maste Subject: Re: savecore(8) increments /var/crash/bounds on each boot X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2005 20:10:10 -0000 On Tue, 14 Jun 2005, 12:08-0700, David O'Brien wrote: > On Tue, Jun 14, 2005 at 10:49:44PM +0400, Maxim Konovalov wrote: > > On Tue, 14 Jun 2005, 01:20-0700, David O'Brien wrote: > > > > > On Mon, Jun 13, 2005 at 03:23:08PM -0400, Ed Maste wrote: > > > > I notice that as of sbin/savecore/savecore.c 1.72 and in 5.4-RELEASE > > > > savecore increments the number in /var/crash/bounds on each boot, > > > > regardless of whether it rebooted due to panic or was a clean shutdown. > > > > Is this the desired behaviour or an unintentional side effect? > > > > > > It is an unintentional side affect. If I wasn't constantly experiencing > > > kernel landminds every time I sit down to do major FreeBSD, I would have > > > gotten to this issue. > > > > I am going to ask re@ for permission to commit the fix if nobody beats > > me. > > Are you sure its correct? Have you tested it with say bounds != 0 and a > few core dumps in /var/crash? No problems so far: qemu6# ls -l /var/crash total 336080 -rw-r--r-- 1 root wheel 3 Jun 14 20:02 bounds -rw------- 1 root wheel 426 Jun 14 19:22 info.10 -rw------- 1 root wheel 426 Jun 14 19:31 info.11 -rw------- 1 root wheel 425 Jun 14 19:49 info.12 -rw------- 1 root wheel 426 Jun 14 19:57 info.13 -rw------- 1 root wheel 462 Jun 14 20:02 info.14 -rw------- 1 root wheel 424 Jun 14 17:44 info.7 -rw-r--r-- 1 root wheel 5 May 8 07:05 minfree -rw------- 1 root wheel 134217728 Jun 14 19:23 vmcore.10 -rw------- 1 root wheel 134217728 Jun 14 19:31 vmcore.11 -rw------- 1 root wheel 134217728 Jun 14 19:50 vmcore.12 -rw------- 1 root wheel 134217728 Jun 14 19:58 vmcore.13 -rw------- 1 root wheel 134217728 Jun 14 20:03 vmcore.14 -rw------- 1 root wheel 134217728 Jun 14 17:45 vmcore.7 qemu6# cat /var/crash/bounds 15 -- Maxim Konovalov