From owner-freebsd-hackers Sun Dec 17 13:19: 1 2000 From owner-freebsd-hackers@FreeBSD.ORG Sun Dec 17 13:18:58 2000 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mta5.rcsntx.swbell.net (mta5.rcsntx.swbell.net [151.164.30.29]) by hub.freebsd.org (Postfix) with ESMTP id 748BE37B400 for ; Sun, 17 Dec 2000 13:18:58 -0800 (PST) Received: from holly.dyndns.org ([208.191.149.190]) by mta5.rcsntx.swbell.net (Sun Internet Mail Server sims.3.5.2000.01.05.12.18.p9) with ESMTP id <0G5Q00LB8DS3UP@mta5.rcsntx.swbell.net> for hackers@FreeBSD.ORG; Sun, 17 Dec 2000 15:16:52 -0600 (CST) Received: (from chris@localhost) by holly.dyndns.org (8.9.3/8.9.3) id PAA56833; Sun, 17 Dec 2000 15:17:36 -0600 (CST envelope-from chris) Date: Sun, 17 Dec 2000 15:17:35 -0600 From: Chris Costello Subject: Re: Why not another style thread? (was Re: cvs commit: src/lib/libc/gen getgrent.c) In-reply-to: <20001217151509.A63051@hamlet.nectar.com> To: "Jacques A. Vidrine" Cc: hackers@FreeBSD.ORG Reply-To: chris@calldei.com Message-id: <20001217151735.D54486@holly.calldei.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii User-Agent: Mutt/0.96.4i References: <200012172110.eBHLAfU46563@freefall.freebsd.org> <20001217151509.A63051@hamlet.nectar.com> Sender: chris@holly.dyndns.org Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sunday, December 17, 2000, Jacques A. Vidrine wrote: > What do folks think about > > 1) if (data) > free(data); > > versus > > 2) free(data); > > versus > > 3) #define xfree(x) if ((x) != NULL) free(x); > xfree(data); 2. The C standard dictates that free() does nothing when it gets a NULL argument. The other two are just extra clutter. -- +-------------------+-------------------------------------------------+ | Chris Costello | This system will self-destruct in five minutes. | | chris@calldei.com | | +-------------------+-------------------------------------------------+ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message