From owner-svn-src-all@FreeBSD.ORG Tue Jul 20 10:15:07 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55EEA1065672; Tue, 20 Jul 2010 10:15:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3]) by mx1.freebsd.org (Postfix) with ESMTP id DB7D58FC1E; Tue, 20 Jul 2010 10:15:06 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id E270141C759; Tue, 20 Jul 2010 12:15:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([192.168.74.103]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id BiMAl1xa7rq9; Tue, 20 Jul 2010 12:15:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 5C2AF41C752; Tue, 20 Jul 2010 12:15:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 728A44448F3; Tue, 20 Jul 2010 10:13:03 +0000 (UTC) Date: Tue, 20 Jul 2010 10:13:03 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Pyun YongHyeon In-Reply-To: <201007192141.o6JLfsr3090971@svn.freebsd.org> Message-ID: <20100720101118.H57851@maildrop.int.zabbadoz.net> References: <201007192141.o6JLfsr3090971@svn.freebsd.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r210263 - head/sys/dev/bce X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2010 10:15:07 -0000 On Mon, 19 Jul 2010, Pyun YongHyeon wrote: > Author: yongari > Date: Mon Jul 19 21:41:54 2010 > New Revision: 210263 > URL: http://svn.freebsd.org/changeset/base/210263 > > Log: > Do not report current link state if interface is not UP. Hmm, not sure what exactly the code change does but by your description I think I would like to be able to see a porper (updated) result in the media: line of ifconfig no matter if it's UP or not. If this doesn't change that behaviour, just ignore me;) > Reviewed by: davidch > > Modified: > head/sys/dev/bce/if_bce.c > > Modified: head/sys/dev/bce/if_bce.c > ============================================================================== > --- head/sys/dev/bce/if_bce.c Mon Jul 19 21:38:15 2010 (r210262) > +++ head/sys/dev/bce/if_bce.c Mon Jul 19 21:41:54 2010 (r210263) > @@ -5855,6 +5855,10 @@ bce_ifmedia_sts(struct ifnet *ifp, struc > > BCE_LOCK(sc); > > + if ((ifp->if_flags & IFF_UP) == 0) { > + BCE_UNLOCK(sc); > + return; > + } > mii = device_get_softc(sc->bce_miibus); > > mii_pollstat(mii); > -- Bjoern A. Zeeb From August on I will have a life. It's now up to you to do the maths and count to 64. -- Bondorf, Germany, 14th June 2010