From owner-freebsd-bugs@FreeBSD.ORG  Sat Sep  6 22:20:11 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EA61AF89
 for <freebsd-bugs@FreeBSD.org>; Sat,  6 Sep 2014 22:20:11 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D198D1CAA
 for <freebsd-bugs@FreeBSD.org>; Sat,  6 Sep 2014 22:20:11 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s86MKBtC007149
 for <freebsd-bugs@FreeBSD.org>; Sat, 6 Sep 2014 22:20:11 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 193400] [mips] r269577 broke operation on MIPS32
Date: Sat, 06 Sep 2014 22:20:12 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: adrian@freebsd.org
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-193400-8-P85aebiEMV@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-193400-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-193400-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Sep 2014 22:20:12 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193400

--- Comment #2 from Adrian Chadd <adrian@freebsd.org> ---
Ok, here's what fixed it (ignore the error checks):

adrian@adrian-hackbox:~/work/freebsd/embedded/head/src/sys % svn diff kern
Index: kern/subr_sfbuf.c
===================================================================
--- kern/subr_sfbuf.c   (revision 271210)
+++ kern/subr_sfbuf.c   (working copy)
@@ -77,6 +77,14 @@
  */
 static struct mtx sf_buf_lock;

+#ifndef SFBUF
+#error wtf?
+#endif
+
+#ifdef SFBUF_OPTIONAL_DIRECT_MAP
+#error wtf?
+#endif
+
 /*
  * Allocate a pool of sf_bufs (sendfile(2) or "super-fast" if you prefer. :-))
  */
@@ -127,6 +135,7 @@
            ("sf_buf_alloc(SFB_CPUPRIVATE): curthread not pinned"));
        hash_list = &sf_buf_active[SF_BUF_HASH(m)];
        mtx_lock(&sf_buf_lock);
+#if 0
        LIST_FOREACH(sf, hash_list, list_entry) {
                if (sf->m == m) {
                        sf->ref_count++;
@@ -141,6 +150,7 @@
                        goto done;
                }
        }
+#endif
        while ((sf = TAILQ_FIRST(&sf_buf_freelist)) == NULL) {
                if (flags & SFB_NOWAIT)
                        goto done;

.. the original MIPS sfbuf code didn't do the refcount stuff; it just allocated
a new page for each sfbuf requested. I don't know how correct that was, but it
worked.

So maybe you've exposed a bug in the MIPS pmap code?


-a

-- 
You are receiving this mail because:
You are the assignee for the bug.