From nobody Sun Apr 6 00:36:07 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZVYLD2ZrLz5sc0d for ; Sun, 06 Apr 2025 00:36:20 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZVYLD0fXxz424d for ; Sun, 06 Apr 2025 00:36:20 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5e677f59438so5001406a12.2 for ; Sat, 05 Apr 2025 17:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743899778; x=1744504578; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HC6e48hj5fV4bmVQlUOmYVHjcxyMODazbJ9pLXpCPLk=; b=kgbsK4gDmOrv2ClAxZ/2IkUigHAqj1LvDjVWjnTfrLG9KjMUy7OV2CK4HYIpD0sT9G Ybrbmx/U8nsO4w2QemniTm9s9irIaAczuqjGbqZjUGsWt3NvNEHENEICS0LVVkWn2G8u SVv03sYhmfHsKZ3qimyU6flrTLU4rD8CY4hoamI3x7NnaDC7iLC2q97dJ3J+3AjLjG4c rL/A1d30MeDWesaw/a9a3tkIIBDOLpPBKprmFtsDEsE9ZMuOQ9CCfR6G4A6ZCrj3ej7N p9N8g5dLyopex7SB13/ENY+Fy9V4lb09kJurPFH0265UfyaaqghmjnifWZWHpdeWHAtf LdRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743899778; x=1744504578; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HC6e48hj5fV4bmVQlUOmYVHjcxyMODazbJ9pLXpCPLk=; b=itbFhRDiKgGt/XzgC5Zl62d0PWfDzBW5sZlwy9DQXp4xK/734dlqIZcdp/kgesFj1C BKhaUzpVdjsaaaPf/t8ZMgzUbmoMM43T6auBof/8PP2m+H0cDEi1jQNbwBzv57Ikcu4G w7DkVYGy+/qKLtjA8EV0hCL6cLpXRQw9XpyxvAel4AkHiYDRqz3hSMTihkmOvd8y8+1H 0YmLUBMLjD8GR1yZxWQlmBFkOOlUUQ7Q5qsHbnSS2m2etv+/FS7Nc0fuM6ULSDaCDtXZ SeL0Q0lyzrHzYvT/n+nXK57bhWV73odoMZh12GgQxqdiTbmo2bygSRQvHMxXZPqD4WW6 brxg== X-Gm-Message-State: AOJu0YxTvjROmfht/AX8DGRATuQ9KwaTKtibQvQIsYwOaAjR+4b7A84N QUGXtWFiXdSRZGI0WTGRwECSnIXY3Tz1wuUs3rfT0tNLYCXvBz5i+yuawCUBkMWWLxyBt+R3me2 zu891CIJVZldFO+DU7UADQS4qgJgyG2Q= X-Gm-Gg: ASbGncv8NKmj5xIG5PDVB9B9XAoVPJLaDcq+WzMbBB4v3g5tOTJrWdrcsDH8j6Ac1Hp p5/kgAhEQDrkCHCMREX3vA7DJ6HHZr7BMHGv37tM4m3NtMeyslr8xf3bUxjnim2quv2cWLsUrUI IKPrNWVEGDvY6HKXY7vnIE4LMKQ6k4+vCbX6RsHMbqgIdtYQbNfgrVcnUxpOBNsxhJM8k= X-Google-Smtp-Source: AGHT+IFRzbTEcA+gSCv9ZCsIuW23ou7umoSzOuVfQgkviSHUCois82GEC9678YmEx4PCnojwVLnCGS1pdRkov0PjBQk= X-Received: by 2002:a05:6402:3584:b0:5e0:9252:3550 with SMTP id 4fb4d7f45d1cf-5f0b5da540bmr6513218a12.2.1743899778079; Sat, 05 Apr 2025 17:36:18 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: <2rq3bpvhclcipvgg3mo4gml7ysuzbvt6rfnzkprceumzeaeh4b@casrpprm6mgt> <4beaxy5dpajikvafxpjogcxrpyuwwicng5ln5rxbxlbzp2o2g7@ib7wo5jzlte4> In-Reply-To: From: Rick Macklem Date: Sat, 5 Apr 2025 17:36:07 -0700 X-Gm-Features: ATxdqUHxn6WiVvneDkLPEZ38boXXnnoIEDu3Uf0LhodP8JApjPv3Z_9oT6UD8t4 Message-ID: Subject: Re: Heads Up: commit 2ec2ba7e232d just hit main To: Shawn Webb Cc: FreeBSD CURRENT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4ZVYLD0fXxz424d X-Spamd-Bar: ---- On Sat, Apr 5, 2025 at 4:43=E2=80=AFPM Shawn Webb wrote: > > On Sat, Apr 05, 2025 at 04:12:15PM -0700, Rick Macklem wrote: > > On Sat, Apr 5, 2025 at 9:12=E2=80=AFAM Shawn Webb wrote: > > > > > > On Sat, Apr 05, 2025 at 08:52:06AM -0700, Rick Macklem wrote: > > > > On Sat, Apr 5, 2025 at 8:50=E2=80=AFAM Rick Macklem wrote: > > > > > > > > > > On Fri, Apr 4, 2025 at 6:27=E2=80=AFPM Shawn Webb wrote: > > > > > > > > > > > > On Sat, Apr 05, 2025 at 01:04:25AM +0000, Shawn Webb wrote: > > > > > > > On Fri, Apr 04, 2025 at 05:40:21PM -0700, Rick Macklem wrote: > > > > > > > > On Fri, Apr 4, 2025 at 10:50=E2=80=AFAM Shawn Webb wrote: > > > > > > > > > > > > > > > > > > On Thu, Apr 03, 2025 at 06:12:59PM -0700, Rick Macklem wr= ote: > > > > > > > > > > On Thu, Apr 3, 2025 at 4:52=E2=80=AFPM Shawn Webb wrote: > > > > > > > > > > > > > > > > > > > > > > On Wed, Apr 02, 2025 at 01:51:26PM -0700, Rick Mackle= m wrote: > > > > > > > > > > > > The commit 2ec2ba7e232d just hit main. I do not th= ink it will > > > > > > > > > > > > cause problems, but it is fairly large. > > > > > > > > > > > > > > > > > > > > > > > > Man page updates will be done as separate commits. > > > > > > > > > > > > > > > > > > > > > > > > Hopefully this will not cause grief, rick > > > > > > > > > > > > > > > > > > > > > > Hey Rick, > > > > > > > > > > > > > > > > > > > > > > The patch review test plan mentions a patch to ZFS it= self to support > > > > > > > > > > > named attributes. Is that patch available somewhere? > > > > > > > > > > The ZFS patch is currently in phabricator as D49654. > > > > > > > > > > Feel free to review it. > > > > > > > > > > > > > > > > > > > > It can also be found at: > > > > > > > > > > https://people.freebsd.org/~rmacklem/zfs-xattr.patch > > > > > > > > > > (this is a smaller diff which can be applied to an up-t= o-date main src > > > > > > > > > > tree easily) > > > > > > > > > > > > > > > > > > Hey Rick, > > > > > > > > > > > > > > > > > > I applied that zfs patch, but trying pathconf(2) on a fil= e on a ZFS > > > > > > > > > dataset with xattr=3Don (which seems to be the default) r= eturns 0. Am I > > > > > > > > > doing something wrong? > > > > > > > > > > > > > > > > > > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > > > > > > > > > hbsd-current-01[shawn]:/home/shawn/tmp $ ./xattrtest xatt= rtest > > > > > > > > > xattrtest: Named attributes not enabled: No error: 0 > > > > > > > > > hbsd-current-01[shawn]:/home/shawn/tmp (1) $ zfs list /us= r/home/shawn > > > > > > > > > NAME USED AVAIL REFER MOUNTPOINT > > > > > > > > > rpool/usr/home 10.4G 71.4G 9.85G /usr/home > > > > > > > > > hbsd-current-01[shawn]:/home/shawn/tmp $ zfs get xattr rp= ool/usr/home > > > > > > > > > NAME PROPERTY VALUE SOURCE > > > > > > > > > rpool/usr/home xattr on default > > > > > > > > > =3D=3D=3D=3D END LOG =3D=3D=3D=3D > > > > > > > > > > > > > > > > > > That xattrtest application is yours from: > > > > > > > > > https://people.freebsd.org/~rmacklem/xattrtest.c > > > > > > > > No idea. It works for me. You used up-to-date kernel source= s? > > > > > > > > (Check that VIRF_NAMEDATTR is defined in sys/sys/vnode.h.) > > > > > > > > Oh, and one more thing to check. zfs_xattr_compat needs to = be non-zero. > > > > > > > > (It's found in sys/contrib/openzfs/module/os/freebsd/zfs/zf= s_vnops_os.c. > > > > > > > > It's initialized to 1 and I don't see anything that sets it= to 0?) > > > > > > > > > > > > > > It is indeed set to 1. > > > > > > > > > > > > > > > > > > > > > > > The only thing I can think if is, if you changed xattr to o= n, you need to > > > > > > > > reboot (or at least remount) to get it to take effect. > > > > > > > > (Maybe try setting it to "dir" and then reboot/remount. May= be there is > > > > > > > > a difference between "on" and "dir"?) > > > > > > > > > > > > > > Yeah, tried rebooting and still no go. Note that xattr defaul= ts to > > > > > > > "on" in FreeBSD by default. My src tree is synced up to FreeB= SD commit > > > > > > > 7e70d94acd68b3ac6b45f49d4ab7a0f7867c3ea7. I brought in the ZF= S patch > > > > > > > you linked to. > > > > > > > > > > > > > > > > > > > > > > > Or, did you build zfs.ko some other way than as part of a k= ernel build? > > > > > > > > (It needs the patched .h files in the kernel sources, not s= omething in > > > > > > > > /usr/include/sys > > > > > > > > that has not yet been updated.) > > > > > > > > All the ZFS changes are #ifdef'd, since OpenZFS requires th= e sources > > > > > > > > build for older kernels. (Basically #ifdef'd on that VIRF_N= AMEDATTR mentioned > > > > > > > > above.) > > > > > > > > > > > > > > Perhaps I need to do a clean build. I'll try that and report = back. > > > > > > > > > > > > > > > > > > > > > > > It does remind me that I need to try a build of zfs.ko by d= oing a "make" in > > > > > > > > the module directory. > > > > > > > > > > > > > > > > You can try the attached trivial patch and see if it spits = out "pathconf ret=3D1" > > > > > > > > on the console. > > > > > > > > > > > > > > I'll try that after a clean rebuild of the kernel. > > > > > > > > > > > > Clean rebuild didn't resolve it. However, I made some progress. > > > > > > > > > > > > I created a dataset specifically for this since I can't really = unmount > > > > > > my /usr/home dataset, so my example down below is a bit differe= nt than > > > > > > the previous example I gave. > > > > > > > > > > > > The xattr property is set to "on" for the dataset. However, it'= s not > > > > > > mounted with the xattr property. In order to get it to work, I = had to > > > > > > run the following commands: > > > > > > > > > > > > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > > > > > > $ sudo zfs umount rpool/scratch/xattr > > > > > > $ sudo mount -t zfs -o xattr rpool/scratch/xattr /scratch/xattr > > > > > > $ zfs get xattr rpool/scratch/xattr > > > > > > NAME PROPERTY VALUE SOURCE > > > > > > rpool/scratch/xattr xattr on local > > > > > > $ mount | grep xattr > > > > > > rpool/scratch/xattr on /scratch/xattr (zfs, local, noatime, nfs= v4acls, named attributes) > > > > > > $ mount | grep named > > > > > > rpool/scratch/xattr on /scratch/xattr (zfs, local, noatime, nfs= v4acls, named attributes) > > > > > > =3D=3D=3D=3D END LOG =3D=3D=3D=3D > > > > > > > > > > > > So it looks like FreeBSD does not honor the xattr zfs property, > > > > > > otherwise you would see a whole bunch of datasets mounted with = the > > > > > > "named attributes" flag in that last `mount | grep` command. > > > > > I've looked at this a little more... > > > > > There is a function xattr_changed_cb() that updates the xattr pro= perty > > > > > information. > > > > > It gets called when "zfs set xattr=3DXX " is done or= when > > > > > the mount option "xattr" is set. > > > > > > > > > > The question seems to be "Why was the stuff not correctly set for= your file > > > > > systems, although they show xattr=3Don?" > > > > > > This is indeed what I was inferring. xattr has been set to "on" since > > > the pool's creation as far as I can tell. Until experimenting with > > > your patch, I didn't really even know the xattr property even existed= . > > I was able to reproduce this with a fresh zpool. > > Although it reported "xattr on", that is not really accurate. > > > > I stuck a printf() in here (line#853-861 of > > sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.) > > > > /* should either have both of these objects or none */ > > error =3D zap_lookup(os, MASTER_NODE_OBJ, ZFS_SA_ATTRS, 8, 1, > > &sa_obj); > > if (error !=3D 0) > > return (error); > > > > error =3D zfs_get_zplprop(os, ZFS_PROP_XATTR, &val); > > --> The printf here shows that error =3D=3D ENOENT. > > if (error =3D=3D 0 && val =3D=3D ZFS_XATTR_SA) > > zfsvfs->z_xattr_sa =3D B_TRUE; > > > > The printf() of error showed ENOENT. So, "xattr" actually does not > > exist. "zfs get xattr " calls it "on" but that's not accur= ate. > > > > As root, I did: > > # zfs set xattr=3Ddir > > - reboot > > > > This makes it work, although the above call still returns ENOENT. > > It looks to me like zfsvfs_init() gets called from zfsvfs_create() > > right at the beginning of zfs_domount(). > > Later in zfs_domount() it calls zfsvfs_setup()->zfs_register_callbacks(= ), > > which now finds the property (because of the "zfs set xattr=3Ddir ") > > and registers it via dsl_prop_register(). > > > > I don't know if the above is correct? > > Personally, I would prefer to see "zfs get xattr " reply "= not set" > > instead of "on". > > > > rick > > > > > > Setting the property makes it work, but only after rebooting > > (a umount/mount would probably have the same effect, I think?). > > So I wonder why neither an unmount/mount nor a reboot causes `mount | > grep "named attribute"` to fail for me. HardenedBSD doesn't have any > changes to ZFS that would cause that kind of behavior. I have to > unmount, but manually mount with `mount -t zfs -o xattr ...` in order > to access the new feature you wrote. Weird. So, you have done # zfs set xattr=3Ddir followed by a reboot and it still doesn't work? rick > > -- > Shawn Webb > Cofounder / Security Engineer > HardenedBSD > > Signal Username: shawn_webb.74 > Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 > https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/0= 3A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc