From owner-freebsd-ports-bugs@freebsd.org  Mon Jan  1 05:21:10 2018
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9C27E89492
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Mon,  1 Jan 2018 05:21:10 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 946147F5BD
 for <freebsd-ports-bugs@FreeBSD.org>; Mon,  1 Jan 2018 05:21:10 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w015LAwM004929
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 1 Jan 2018 05:21:10 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
Received: (from www@localhost)
 by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w015LAbP004928
 for freebsd-ports-bugs@FreeBSD.org; Mon, 1 Jan 2018 05:21:10 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
X-Authentication-Warning: kenobi.freebsd.org: www set sender to
 bugzilla-noreply@freebsd.org using -f
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 224808] New x11-fonts/nerd-fonts-complete 1.2.0
Date: Mon, 01 Jan 2018 05:21:07 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: jrm@freebsd.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-224808-13-HtZPTnBf8r@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-224808-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-224808-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jan 2018 05:21:10 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224808

Joseph Mingrone <jrm@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jrm@freebsd.org

--- Comment #1 from Joseph Mingrone <jrm@freebsd.org> ---
- You need to start with the line
# $FreeBSD$

- Why not PORTNAME=3Dnerd-fonts, then you can remove GH_PROJECT=3D nerd-fon=
ts.

- COMMENT is too long and should not start with 'A".  Maybe:
COMMENT=3DCollection of over 20 patched fonts

- The block order should conform to 'Order of Variables in Port Makefiles' =
in
the Porter's Handbook.
USES=3D           fonts
USE_GITHUB=3D     yes
GH_ACCOUNT=3D     ryanoasis

NO_ARCH=3D        yes
NO_BUILD=3D       yes

There are pkg-plist issues because of empty directories.  Maybe add this to=
 the
do-install target.

        @${RMDIR} ${STAGEDIR}${FONTSDIR}/ProFont/ProFontWinTweaked/complete=
 \
                ${STAGEDIR}${FONTSDIR}/ProFont/ProFontWinTweaked \
                ${STAGEDIR}${FONTSDIR}/ProFont/profont-x11 \
                ${STAGEDIR}${FONTSDIR}/Terminus/BDF \
                ${STAGEDIR}${FONTSDIR}/Terminus/PCF \
                ${STAGEDIR}${FONTSDIR}/Terminus/PSF \

ports-mgmt/portlint is helpful for detecting issues (but is not perfect).

--=20
You are receiving this mail because:
You are the assignee for the bug.=