Date: Wed, 29 Aug 2012 22:19:59 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Garrett Cooper <yanegomi@gmail.com> Cc: ports@freebsd.org, Eitan Adler <eadler@freebsd.org>, portmgr@freebsd.org Subject: Re: Regression in PREFIX handling in packages Message-ID: <20120829221959.00002237@unknown> In-Reply-To: <CAGH67wTyW3oWB0w0pO5fU%2BpgNntxSrxkpXD3C5J3TEa4AO6mjQ@mail.gmail.com> References: <20120826225435.00005a10@unknown> <20120829211753.0000399e@unknown> <CAF6rxgmyO_4tnfOfRNZU_qkc0aMuojEjbj52H%2B_BfRD4Jdxp-w@mail.gmail.com> <20120829214831.000050c8@unknown> <CAGH67wTyW3oWB0w0pO5fU%2BpgNntxSrxkpXD3C5J3TEa4AO6mjQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 29 Aug 2012 12:59:30 -0700 Garrett Cooper <yanegomi@gmail.com> wrote: > On Wed, Aug 29, 2012 at 12:48 PM, Alexander Leidinger > <Alexander@leidinger.net> wrote: > > On Wed, 29 Aug 2012 15:28:36 -0400 Eitan Adler <eadler@freebsd.org> > > wrote: > > > >> On 29 August 2012 15:17, Alexander Leidinger > >> <Alexander@leidinger.net> wrote: > >> > Could it be that my problem comes from r231300 and I was lucky > >> > that I didn't create a package on the machine with the > >> > symlinked /usr/local and used it on a machine with a > >> > normal /usr/local? > > Symlinking would be a problem if you built it on one machine and > installed it on another. I use this approach since years, and at least with the packages I created on the machine with the symlink I never had problems. This should only cause problems where realpath is used on a dependency during the configuration/build of a port. I don't want to rule out such a case, but I assume it is not a case one can fall into much. > > Wouldn't it be better to use > > ---snip--- > > if (Prefix[0] != '/' && realpath(... > > ---snip--- > > in this case? Attention: I just guessed what Prefix is and what it > > should contain by looking at the diff, I didn't had a look at the > > declaraction and assignments of Prefix. > > That would cause problems in some cases where someone called > pkg_create -p /usr/foobar/../local > > If this commit causes more harm than good, please back it out -- > pkg_install is going to die soon anyhow, so I'd rather not fritter > away time debating its usefulness if it breaks a valid use case. See my other mail, the patch there works for me. Only if the Prefix is not an absolute path, the realpath is used. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120829221959.00002237>