From owner-freebsd-stable Thu Apr 13 16: 8:48 2000 Delivered-To: freebsd-stable@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 2B37D37BA6F; Thu, 13 Apr 2000 16:08:46 -0700 (PDT) (envelope-from kris@FreeBSD.org) Received: from localhost (kris@localhost) by freefall.freebsd.org (8.9.3/8.9.2) with ESMTP id QAA46405; Thu, 13 Apr 2000 16:08:46 -0700 (PDT) (envelope-from kris@FreeBSD.org) X-Authentication-Warning: freefall.freebsd.org: kris owned process doing -bs Date: Thu, 13 Apr 2000 16:08:46 -0700 (PDT) From: Kris Kennaway To: Warner Losh Cc: "Jordan K. Hubbard" , Robin Melville , Doug Barton , stable@FreeBSD.ORG Subject: Re: 4.0, OpenSSL and MD5 (fwd) In-Reply-To: <200004132239.QAA48615@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 13 Apr 2000, Warner Losh wrote: > Most of the rest. Things like NOPROFILE the value is also checked. I beg to differ..bsd.lib.mk only does ".if defined(NOPROFILE)" > Personally, I think *ALL* of them should be checked for yes vs no > (both cases), but that would be a huge PITA to get right. However, it > should be done in the least pain way, eg > > .if !defined(NOFOO) && ${NOFOO} != "no" && ${NOFOO} != "NO" > > so that you can have NOFOO?=yes in your make.conf file and still say > NOFOO=no on the command line. You're right that it would be a huge PITA :-) The checks are complicated enough already - they simplify when you condense the various compatible options together in Makefile.inc1, but it's still hairy. I'll try and clean up my NOFOO -> NO_FOO patch in the next few days so we can move forward in this area. Kris ---- In God we Trust -- all others must submit an X.509 certificate. -- Charles Forsythe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message