Date: Mon, 10 Oct 2016 10:21:19 -0700 From: Conrad Meyer <cem@freebsd.org> To: Ruslan Bukin <ruslan.bukin@cl.cam.ac.uk> Cc: Ruslan Bukin <br@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306962 - head/tests/sys/kern/pipe Message-ID: <CAG6CVpV4vcSYsyH4RWauh1hnxmtywxLrzvD43dUMDJXty%2BPZoQ@mail.gmail.com> In-Reply-To: <20161010165038.GA31246@bsdpad.com> References: <201610101340.u9ADe5XW093068@repo.freebsd.org> <CAG6CVpU%2B-pbFe4ogzvnUEKB4iSRRx-o_W1qFVj-2igxPL6TmzQ@mail.gmail.com> <20161010165038.GA31246@bsdpad.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 10, 2016 at 9:50 AM, Ruslan Bukin <ruslan.bukin@cl.cam.ac.uk> wrote: > On Mon, Oct 10, 2016 at 08:04:44AM -0700, Conrad Meyer wrote: >> We also observed this test was broken, but I think the right fix is >> much smaller: >> >> --- a/tests/sys/kern/pipe/pipe_fstat_bug_test.c >> +++ b/tests/sys/kern/pipe/pipe_fstat_bug_test.c >> @@ -108,7 +108,6 @@ main(void) >> SYNC_W(0, go2); >> >> SYNC_R(0, go); >> - SYNC_W(0, go2); /* XXX: why is this required? */ >> WRITE(8192); >> SYNC_W(0, go2); >> >> (That line breaks the synchronization mechanism that is the only >> guarantee the test passes.) > > There is some direct mode activated when you send >=8192, > so this line is required Given that line breaks the parent-child synchronization entirely and your kevent replaces it, why not remove the remaining go/go2 pipe and read/writes? Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpV4vcSYsyH4RWauh1hnxmtywxLrzvD43dUMDJXty%2BPZoQ>