From nobody Sat Dec 3 17:15:06 2022 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NPbzH6Brkz4ht0g for ; Sat, 3 Dec 2022 17:15:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NPbzH544mz44HV for ; Sat, 3 Dec 2022 17:15:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670087707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+9f/W7GgDrt6uDprmcsWr5VcyItvOIukEpUorhw/AJk=; b=n+UMueZxlwbyFH84YyGKRjhhrVsryzMnRb88sopAMFEQ3rx6eQIk746JXViNUoe0ZeNRMu opW2OBknY0HNwnWEiy3zp9INftXbuMaNmPTH7MMt0mnTP6Hk8EYM5EdHChBUQ0GcaKbuP/ bOdF7z5+TMKHHYBvjXEQpuVgvHOMDfqGnT5z77QAukq8XLRbPWWqUcg9UxtnbiIvDZGHAk U1CjhjrK8xmjR5lVEhyY3nJH6NkW07DaL9zwowV2+X2l5dnnYCbP0y7juTTKYEavJPhRtj C/PqHEn0LE6ujRroC5R1tVt3oZM6c0ZSr0s1WZqRXyEmliH3IPcofHNcBFX0Vw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670087707; a=rsa-sha256; cv=none; b=mZ4aOIwXq837h8Cxzg2LM2eND9Oi/+B0FvP1I0ZXpAaF/wBwcuNmblDWuSPZwNmVypHfIQ h+g1Qtkzhy+oCLOxDWjjAExMUq8juMmTKIxhc64H/5su7U6VtDtNrS2PkcWC4giRZxzjfw 977jro9/2RqdGTmV9GossJwr7+rFjsiK+U8aD4fM9e0/wPxNr+CUfR5Gq1bHtl9oGF1h4W 2TXpFqYwYM3Ljhq0U20kis2uteWULYC8jII8VewU5bJiy/H1VHh8c9Y3E9qdKIVmcfR0z5 /AzWkvUuXAaVoHofS9RUaedY5tkyLj/VIunWM447l+s2oaVas85dNNNx/XA/5Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NPbzH411Gz12YH for ; Sat, 3 Dec 2022 17:15:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2B3HF7uI046100 for ; Sat, 3 Dec 2022 17:15:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2B3HF7Ii046099 for virtualization@FreeBSD.org; Sat, 3 Dec 2022 17:15:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 267539] Bhyve virtio-scsi warnings about illegal SCSI tag reuse Date: Sat, 03 Dec 2022 17:15:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267539 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D7467a6953683b439f7b31c2b42533cb89= 3ed6be3 commit 7467a6953683b439f7b31c2b42533cb893ed6be3 Author: Alexander Motin AuthorDate: 2022-12-03 17:05:05 +0000 Commit: Alexander Motin CommitDate: 2022-12-03 17:05:05 +0000 CTL: Allow userland supply tags via ioctl frontend. Before this ioctl frontend always replaced tags with sequential ones. It was done for ctladm, that can not keep track of global tag list. But in case of virtio-scsi in bhyve we can pass provided tags as-is. It should be on virtio-scsi initiator to provide us valid tags. It should allow proper task management, error reporting, etc. In case of several virtio-scsi devices, they should use different CTL ports or initiator IDs to avoid conflicts, but this is expected by design. PR: 267539 sys/cam/ctl/ctl_frontend_ioctl.c | 5 +++-- sys/cam/ctl/ctl_io.h | 2 +- usr.sbin/bhyve/pci_virtio_scsi.c | 2 ++ 3 files changed, 6 insertions(+), 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=