From owner-freebsd-mips@FreeBSD.ORG  Fri Apr 30 16:45:35 2010
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 71946106568C;
	Fri, 30 Apr 2010 16:45:35 +0000 (UTC)
	(envelope-from c.jayachandran@gmail.com)
Received: from mail-ew0-f224.google.com (mail-ew0-f224.google.com
	[209.85.219.224])
	by mx1.freebsd.org (Postfix) with ESMTP id 9A2858FC12;
	Fri, 30 Apr 2010 16:45:34 +0000 (UTC)
Received: by ewy24 with SMTP id 24so118403ewy.33
	for <multiple recipients>; Fri, 30 Apr 2010 09:45:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:date:from:to:cc:subject
	:message-id:mime-version:content-type:content-disposition:user-agent;
	bh=ZMWmPrRzROEcEBlYKnMgG6MY8sgUd4cC3I1u04MLm7c=;
	b=vlb9rUfCB9O1OE3b47aGw7Y2JY4HkHxwr1O737pUncWUqllUKyk6PqSkinsOM/f/LS
	4pVDL7VAGrg3tIx6S/AIZ6Cl9LbXCiYLFRi2wNhoY0NKLRSRDqauo6Huis0ODn/8l6Lc
	y51d4z7IqgWuUoTYw5YyWAPqS6UdVdOfdEieY=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=date:from:to:cc:subject:message-id:mime-version:content-type
	:content-disposition:user-agent;
	b=RWzoAVZnzmKl9Ms+ziuE7D6URRTyoiyStfN27AQeo5RXXatVmw4UqP+GWZsSFQYR6R
	EWe1yXT89v4Ipns3ILMt0EhG/t0cLDzkO0Zgb/iRBgv8/RnBD27oYbc8Vp+IeYeOw2OR
	2wZoaRpot50kp3MLFF/685aTNdvyElQcG8Vds=
Received: by 10.213.52.208 with SMTP id j16mr4250548ebg.39.1272645928784;
	Fri, 30 Apr 2010 09:45:28 -0700 (PDT)
Received: from jayachandranc@netlogicmicro.com ([203.92.57.132])
	by mx.google.com with ESMTPS id 13sm1322465ewy.13.2010.04.30.09.44.41
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Fri, 30 Apr 2010 09:44:48 -0700 (PDT)
Date: Fri, 30 Apr 2010 22:18:52 +0530
From: "Jayachandran C." <c.jayachandran@gmail.com>
To: Juli Mallett <jmallett@freebsd.org>
Message-ID: <4bdb0900.0d67f10a.0ae4.7784@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: freebsd-mips@freebsd.org
Subject: Fix for pmap.c
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Apr 2010 16:45:35 -0000

There seems to be a obvious bug in the current pmap.c, can you please
review/apply the patch below.

This seems to be the cause of the crashes I'm seeing in HEAD. I'm still
testing with the patch, the buildworld I use will have to run a few more
hours to be completely sure that this is the problem.

JC.


Index: sys/mips/mips/pmap.c
===================================================================
--- sys/mips/mips/pmap.c	(revision 207433)
+++ sys/mips/mips/pmap.c	(working copy)
@@ -236,7 +236,7 @@
 	sched_pin();							\
 	va1 = sysm->base;						\
 	va2 = sysm->base + PAGE_SIZE;					\
-	npte = mips_paddr_to_tlbpfn(phys2) |				\
+	npte = mips_paddr_to_tlbpfn(phys1) |				\
 	    PTE_RW | PTE_V | PTE_G | PTE_W | PTE_CACHE;			\
 	pte = pmap_pte(kernel_pmap, va1);				\
 	*pte = npte;							\