From owner-p4-projects@FreeBSD.ORG Thu Dec 1 19:51:03 2005 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id C238016A422; Thu, 1 Dec 2005 19:51:02 +0000 (GMT) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 85DF316A41F for ; Thu, 1 Dec 2005 19:51:02 +0000 (GMT) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4FB0543D53 for ; Thu, 1 Dec 2005 19:51:02 +0000 (GMT) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jB1Jp2Xx072028 for ; Thu, 1 Dec 2005 19:51:02 GMT (envelope-from millert@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jB1Jp2PH072025 for perforce@freebsd.org; Thu, 1 Dec 2005 19:51:02 GMT (envelope-from millert@freebsd.org) Date: Thu, 1 Dec 2005 19:51:02 GMT Message-Id: <200512011951.jB1Jp2PH072025@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to millert@freebsd.org using -f From: Todd Miller To: Perforce Change Reviews Cc: Subject: PERFORCE change 87593 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2005 19:51:03 -0000 http://perforce.freebsd.org/chv.cgi?CH=87593 Change 87593 by millert@millert_ibook on 2005/12/01 19:50:01 mach_init was not handling waitpid returning EINTR, which caused zombies to pile up over time. Affected files ... .. //depot/projects/trustedbsd/sedarwin7/src/darwin/system_cmds/mach_init.tproj/bootstrap.c#5 edit Differences ... ==== //depot/projects/trustedbsd/sedarwin7/src/darwin/system_cmds/mach_init.tproj/bootstrap.c#5 (text+ko) ==== @@ -594,7 +594,9 @@ /* * Reap our children. */ - presult = waitpid(serverp->pid, &wstatus, WNOHANG); + do { + presult = waitpid(serverp->pid, &wstatus, WNOHANG); + } while (presult == -1 && errno == EINTR); if (presult != serverp->pid) { unix_error("waitpid: cmd = %s", serverp->cmd); } else if (wstatus) {