From owner-freebsd-arm@FreeBSD.ORG  Thu May  7 16:17:17 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 19178F59
 for <freebsd-arm@freebsd.org>; Thu,  7 May 2015 16:17:17 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F09651AE1
 for <freebsd-arm@freebsd.org>; Thu,  7 May 2015 16:17:16 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t47GHGX1080825
 for <freebsd-arm@freebsd.org>; Thu, 7 May 2015 16:17:16 GMT
 (envelope-from daemon-user@phabric-backend.isc.freebsd.org)
Received: (from daemon-user@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t47GHGev080824;
 Thu, 7 May 2015 16:17:16 GMT (envelope-from daemon-user)
Date: Thu, 7 May 2015 16:17:16 +0000
To: freebsd-arm@freebsd.org
From: "andrew (Andrew Turner)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Accepted] D2357: Port x86 busdma to ARM64
Message-ID: <4d5d3a205ede0ea7d2a735800ce27fa4@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2357: Port x86 busdma to ARM64
X-Herald-Rules: <34>
X-Phabricator-To: <PHID-USER-6m5mo2kjikkzyd33ld4n>
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-yhwnadxnjthofqelhkdx>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-Cc: <PHID-USER-xvjulcphpj66vffzpxft>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-h7f3zkqdq4qxyli7oe3v-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-h7f3zkqdq4qxyli7oe3v-req@FreeBSD.org>
Thread-Index: MGY3ZjQ1YWY5OGJjZWFlYzE0YWJhYTBhN2U5IFVLkAw=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-other>, <differential-reviewers>,
 <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 May 2015 16:17:17 -0000

andrew accepted this revision.
andrew added a comment.
This revision has a positive review.

Only a few minor issues.


INLINE COMMENTS
  sys/arm64/arm64/busdma_bounce.c:202 Wouldn't error already be zero in this case?
  sys/arm64/arm64/busdma_bounce.c:323 Extra braces
  sys/arm64/arm64/busdma_machdep.c:127 Could you provide a better error string here?
  sys/arm64/arm64/busdma_machdep.c:133 We only return a NULL tag on some failures? There is a case on the previous line where it could fail without the tag set.
  sys/arm64/include/bus_dma_impl.h:32 There should be no tab after `#ifndef`

REVISION DETAIL
  https://reviews.freebsd.org/D2357

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew
Cc: onwahe-gmail-com, emaste, freebsd-arm