From owner-freebsd-current@freebsd.org Fri Aug 21 13:29:29 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F17CC9BD95B for ; Fri, 21 Aug 2015 13:29:29 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D9796F2 for ; Fri, 21 Aug 2015 13:29:29 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id D6A8B9BD958; Fri, 21 Aug 2015 13:29:29 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D643F9BD957 for ; Fri, 21 Aug 2015 13:29:29 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f]) by mx1.freebsd.org (Postfix) with ESMTP id BA46BF0; Fri, 21 Aug 2015 13:29:29 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from marvin.beer.town (unknown [76.164.8.130]) by smtp.vangyzen.net (Postfix) with ESMTPSA id D4F6B56486; Fri, 21 Aug 2015 08:29:27 -0500 (CDT) Subject: Re: 11-CURRENT build fail with base gcc To: Warner Losh , Dimitry Andric References: <349EA432-E76D-4D1B-9383-E707967C806D@bsdimp.com> <30F511DD-2C7C-4252-8870-AC15B36FF36A@bsdimp.com> Cc: Oliver Pinter , current@freebsd.org, imp@freebsd.org From: Eric van Gyzen X-Enigmail-Draft-Status: N1110 Message-ID: <55D727B3.801@FreeBSD.org> Date: Fri, 21 Aug 2015 08:29:23 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <30F511DD-2C7C-4252-8870-AC15B36FF36A@bsdimp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Aug 2015 13:29:30 -0000 On 08/20/2015 14:21, Warner Losh wrote: > >> On Aug 20, 2015, at 10:32 AM, Dimitry Andric wrote: >> >> Ah, this should be replaced with the recently introduced CFLAGS_NO_SIMD >> variable, then? > > Perhaps. Didn’t know this was a thing. That could use useful many places, though > there were two clang specific args I needed to move, not just the one that’s in this > flag. Maybe things are over-specified? > > Not sure I like bsd.cpu.mk growing more name-space pollution, especially stuff that > isn’t documented somewhere (bsd.cpu.mk is included from sys.mk, which is automaticallyed > globally included). I couldn't find any _good_ place for it, so I stuck it in the least bad place. I also didn't know where to document it. I'll gladly move it and document it if someone can suggest good locations. > All these hacks being stashed hither and yon are starting to get > very hard to keep straight for someone who looks at this code every day, let alone > somebody who invested CFLAGS_NO_SIMD independently for their code and finds > that breaks in an upgrade...