From owner-cvs-src@FreeBSD.ORG Tue May 27 23:21:46 2008 Return-Path: <owner-cvs-src@FreeBSD.ORG> Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BEF7E1065678; Tue, 27 May 2008 23:21:46 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 5354E8FC1A; Tue, 27 May 2008 23:21:46 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [202.108.54.204]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 58F3128448; Wed, 28 May 2008 07:21:45 +0800 (CST) Received: from localhost (tarsier.geekcn.org [202.108.54.204]) by tarsier.geekcn.org (Postfix) with ESMTP id E63DBEBB8DF; Wed, 28 May 2008 07:21:44 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([202.108.54.204]) by localhost (mail.geekcn.org [202.108.54.204]) (amavisd-new, port 10024) with ESMTP id IDBvx-VnJzRa; Wed, 28 May 2008 07:21:39 +0800 (CST) Received: from charlie.delphij.net (71.5.7.139.ptr.us.xo.net [71.5.7.139]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 371FEEBB8D9; Wed, 28 May 2008 07:21:38 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=k/+yTWpueHUD1C5xeq5S64a0yV2WSk6g3Bzmc6WtbmM9qLz/fg14UHEJfxUtdRSnb 0V6iWKFhjJy9QWQafhPLQ== Message-ID: <483C977F.20105@delphij.net> Date: Tue, 27 May 2008 16:21:35 -0700 From: Xin LI <delphij@delphij.net> Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.14 (X11/20080505) MIME-Version: 1.0 To: Maxim Sobolev <sobomax@FreeBSD.ORG> References: <200805272004.m4RK4SZt029194@repoman.freebsd.org> <483C7FF2.6000607@FreeBSD.org> In-Reply-To: <483C7FF2.6000607@FreeBSD.org> X-Enigmail-Version: 0.95.6 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, Xin LI <delphij@FreeBSD.ORG>, re@FreeBSD.org, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/include string.h src/lib/libc/string Makefile.inc memchr.3 memrchr.c src/sys/sys param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-src> List-Post: <mailto:cvs-src@freebsd.org> List-Help: <mailto:cvs-src-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 27 May 2008 23:21:46 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Maxim Sobolev wrote: | Xin LI wrote: |> delphij 2008-05-27 20:04:27 UTC |> |> FreeBSD src repository |> |> Modified files: (Branch: RELENG_6) |> include string.h lib/libc/string |> Makefile.inc memchr.3 sys/sys param.h Added |> files: (Branch: RELENG_6) |> lib/libc/string memrchr.c Log: |> MFC: Add memrchr(3). | | I think this is not very good idea to MFC that into stable releases 6.x | and 7.x. The reason is that configure scripts for some packages might | detect up this API and enable it. Which means that some binary-only | packages build for say 6.4 won't work on 6.3 and down. AFAIK, both | forward and backward compatibility is required (or at least desired?) | for stable branches. | | While it's "nice-to-have" feature, I see no pressing need to MFC this | interface. I don't think so, perhaps I am wrong, but do we really want absolutely no *new* features on -STABLE branches? I think this case is different from ctype(3) fix which is widely used API and a change of existing interface by adding new dependency to a symbol that is not exist in the older FreeBSD releases. It will really scare me away from any new features if we can not add an new interface in RELENG_* trees even if they have no outside dependencies, if that's the policy of ABI compatibility guidelines then I'd be happy to revert these MFC's, but having something can only run on -CURRENT does not sound like a good idea, and maintaining in-tree alternative patches for different branches for such things is really painful and will likely reduce the lifespan of given -STABLE branches, is these our goal and should be kept in mind when maintaining code in RELENG_* branches? Cheers, - -- ** Help China's quake relief at http://www.redcross.org.cn/ |>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkg8l38ACgkQi+vbBBjt66CQpwCfas0aJ1oHSGKaSZxuu4qaCMGR ZXYAniELjdnA0zuw2LmGkk2wXCZ7GFLW =dFm9 -----END PGP SIGNATURE-----