From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Oct 14 12:10:01 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9E397A22 for ; Sun, 14 Oct 2012 12:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [8.8.178.135]) by mx1.freebsd.org (Postfix) with ESMTP id 7550B8FC1B for ; Sun, 14 Oct 2012 12:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q9ECA1F2078918 for ; Sun, 14 Oct 2012 12:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q9ECA122078917; Sun, 14 Oct 2012 12:10:01 GMT (envelope-from gnats) Resent-Date: Sun, 14 Oct 2012 12:10:01 GMT Resent-Message-Id: <201210141210.q9ECA122078917@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jukka Ukkonen Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CFCC4609 for ; Sun, 14 Oct 2012 12:02:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id B8B058FC1E for ; Sun, 14 Oct 2012 12:02:03 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q9EC21a9033784 for ; Sun, 14 Oct 2012 12:02:01 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q9EC21ra033783; Sun, 14 Oct 2012 12:02:01 GMT (envelope-from nobody) Message-Id: <201210141202.q9EC21ra033783@red.freebsd.org> Date: Sun, 14 Oct 2012 12:02:01 GMT From: Jukka Ukkonen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/172689: Problem building hercules + patch X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2012 12:10:01 -0000 >Number: 172689 >Category: ports >Synopsis: Problem building hercules + patch >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Oct 14 12:10:01 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Jukka Ukkonen >Release: 9.1-PRERELEASE >Organization: ----- >Environment: FreeBSD sleipnir 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0: Sat Oct 13 10:39:00 EEST 2012 root@sleipnir:/usr/obj/usr/src/sys/Sleipnir amd64 >Description: There was a problem with hercules. The build failed due to faulty setsockopt() parameters to set TCP keepalive values. Find a patch attached. Bjoern Zeeb has already seen the patch and advised me to mention "Approved by maintainer." >How-To-Repeat: Try building hercules without the patch. >Fix: Add the attached patch files as hercules/files/patch-hscutl.c and ... make clean make Patch attached with submission follows: --- hscutl.c.orig 2012-10-14 08:47:02.252508688 +0300 +++ hscutl.c 2012-10-14 08:48:03.485519701 +0300 @@ -704,7 +704,7 @@ if (rc) logmsg("HHCUT002I TCP_KEEPALIVE rc=%d %s\n", rc, strerror(errno)); #elif defined(TCP_KEEPIDLE) optval = idle_time; - rc = setsockopt(sfd, SOL_TCP, TCP_KEEPIDLE, &optval, sizeof(optval)); + rc = setsockopt(sfd, IPPROTO_TCP, TCP_KEEPIDLE, &optval, sizeof(optval)); if (rc) logmsg("HHCUT003I TCP_KEEPIDLE rc=%d %s\n", rc, strerror(errno)); #else UNREFERENCED(idle_time); @@ -712,7 +712,7 @@ #if defined(TCP_KEEPINTVL) optval = probe_interval; - rc = setsockopt(sfd, SOL_TCP, TCP_KEEPINTVL, &optval, sizeof(optval)); + rc = setsockopt(sfd, IPPROTO_TCP, TCP_KEEPINTVL, &optval, sizeof(optval)); if (rc) logmsg("HHCUT004I TCP_KEEPINTVL rc=%d %s\n", rc, strerror(errno)); #else UNREFERENCED(probe_interval); @@ -720,7 +720,7 @@ #if defined(TCP_KEEPCNT) optval = probe_count; - rc = setsockopt(sfd, SOL_TCP, TCP_KEEPCNT, &optval, sizeof(optval)); + rc = setsockopt(sfd, IPPROTO_TCP, TCP_KEEPCNT, &optval, sizeof(optval)); if (rc) logmsg("HHCUT005I TCP_KEEPCNT rc=%d %s\n", rc, strerror(errno)); #else UNREFERENCED(probe_count); >Release-Note: >Audit-Trail: >Unformatted: