From owner-freebsd-ports@FreeBSD.ORG Fri Nov 28 04:13:43 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A482B16A4CE; Fri, 28 Nov 2003 04:13:43 -0800 (PST) Received: from postman.arcor.de (postman1.arcor-online.net [151.189.0.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8FF9344039; Fri, 28 Nov 2003 04:13:28 -0800 (PST) (envelope-from eik@FreeBSD.org) Received: from FreeBSD.org (p5080BB5F.dip.t-dialin.net [80.128.187.95]) (authenticated bits=0) by postman.arcor.de (8.12.9/8.12.9) with ESMTP id hASCDKNk007000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 28 Nov 2003 13:13:21 +0100 (MET) Message-ID: <3FC73BE1.50301@FreeBSD.org> Date: Fri, 28 Nov 2003 13:13:21 +0100 From: Oliver Eikemeier Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 X-Accept-Language: en, de MIME-Version: 1.0 To: Sergey Matveychuk References: <3FC62330.6060507@FreeBSD.org> <3FC6BB72.9080202@ciam.ru> In-Reply-To: <3FC6BB72.9080202@ciam.ru> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: FreeBSD ports cc: Tom Hukins cc: Joe Marcus Clarke Subject: Re: PORTVERSION and portlint X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2003 12:13:43 -0000 Sergey Matveychuk wrote: > Oliver Eikemeier wrote: > >> and realized that 1.0.1+2003.11.27 < 1.0+2003.10.03, try >> >> pkg_version -t 1.0.1+2003.11.27 1.0+2003.10.03 > > I think it should be fixed. Probably it would be a good thing to have multi-version numbers, and I'm happy to build this in my pkg_version patches. But this is an functional enhancement, not a fix, and would require a MFC. The plus sign is illegal and unsupported with the current package tools. >> I would >> keep that error, or at least issue a warning. The ports should use >> >> PORTVERSION= ${VERSION_ONE}.${VERSION_TWO} > > Yes, I see. But russian/apache13-modssl use > PORTVERSION= ${VERSION_APACHE}+${VERSION_RA}+${VERSION_MODSSL} > > If we change '+' with '.' we'll get something not readable: > 1.3.29.30.19.2.8.16 > > Where is apache version, nodssl version? You can't say without look at > port Makefile. You're not really supposed to be able to do that, the premier purpose of version numbers is to enable automated processing of packages for tools like portupgrade. On the other hand I agree that is is a nice extra if the version numbers are human readable. You could use 1.3.29.x.30.19.x.2.8.16, which isn't as pretty as the plus sign, but gives you 1.0.1.x.2003.11.27 > 1.0.x.2003.10.03 I think it would be nice to extend the functionality of the package tools, but you have to do more than just declare `+' to be a legal separator, you need: - portmgr@ to approve the changes - to MFC, replacing -STABLES perl pkg_version or adapt that too - an mechanism to update the tools of older releases - to adapt all other tools, like sysutils/portupgrade I'm happy to provide the patches and a mechanism to get that to work on older releases. -Oliver