From owner-freebsd-current@freebsd.org Fri Feb 15 19:32:17 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A5B514E661F for ; Fri, 15 Feb 2019 19:32:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7C9F6816E0 for ; Fri, 15 Feb 2019 19:32:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 4056914E661D; Fri, 15 Feb 2019 19:32:16 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18A6314E661C for ; Fri, 15 Feb 2019 19:32:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A095A816D9 for ; Fri, 15 Feb 2019 19:32:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x743.google.com with SMTP id y195so6372835qka.12 for ; Fri, 15 Feb 2019 11:32:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M7eAMyNLdwHUj4uothylBAl2W3dct4RVYrsFybye6P4=; b=VH6LZAS1dTiBf5YEqFoIXAC7djo7L9OUUB2hYnRBL/ui/Gnx5ZyI5N6ZaCAwVBHIYn 0pxG5/a2lBxy1ayzTo51Ry8X7RYbMuEF1mjDkomyGObesTlFOhhcuqD1M+dmSk2ASV+U Y5k04FClzulj2VuFb30MjqfthpQkuE6+MndtscaS1Zih/YvAX+5W0MFoI8fedq8MEpuJ Tf7PVxxJ9fM376qWmCiAM+U8YJzidFmFFiyTjcrq2hj3jLDo/JI+/OO4g5s5NbWHIM05 K7QyTbX2HpNjfe43KNUfX/MQqTpPDy/2O8oO/4Gb97u2LC/FQiOQ95EGFKVQ/ehkkj9c UFvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M7eAMyNLdwHUj4uothylBAl2W3dct4RVYrsFybye6P4=; b=mRgeoBBL1XQhJD8+NhJsZeLJiYcevlWR/xLBiKBat5zEVNmL6Ir7WXk3OtYSVGVrqq qNGnG+NVlvS6b1IYBU1XOP5xvKhBb/AHHPHqma6m8mbZISEKBQn47ppmok5SrjmRvsdM p/c/4wixEw1PhVHmkcIjIVQF4UAtHw0hZF2w2UYJfKBKWrsYZNF6lyFrlloDvUd174FX P2YUVjes8oI+oyuIFqEZWgg0wUErhyaufMQnLMVVG/XG9r3XoHoBMoDNYuZdNwW5zv8Y 2yRsfDgbhu/jmvmgVjcStTP+LcpyRPGMbg2Ob1rMGgSGK3hvQ7QFOeQWjcHK7Z5nkXD7 4Ygw== X-Gm-Message-State: AHQUAubnc4rQTnrDPlL8u6MWLCQoH+GRnnUQxV23cDkBIpkcGtA5KloG ObAGeh7VFP2svnVdULsyKLyV9wvh8MxC8BKciFB2ZA== X-Google-Smtp-Source: AHgI3IayGpyBIfDDEIrrdIjY753jgMH7yaXxkvOrqIMnVbABj4Xr1XEil9/ybjUtVz0SG43ySFoS/UkycxnHmPLXedw= X-Received: by 2002:a37:a407:: with SMTP id n7mr6080885qke.46.1550259134834; Fri, 15 Feb 2019 11:32:14 -0800 (PST) MIME-Version: 1.0 References: <23653.56460.521599.489556@jerusalem.litteratus.org> <754B5C21-656B-4A67-BA39-50BB4AF5C0CD@gmail.com> <652F1541-52DE-4744-8AEA-8EE6434E04E8@gmail.com> <39629f6cb41cff32b348cf5d329d425352c28464.camel@freebsd.org> In-Reply-To: <39629f6cb41cff32b348cf5d329d425352c28464.camel@freebsd.org> From: Warner Losh Date: Fri, 15 Feb 2019 12:32:03 -0700 Message-ID: Subject: Re: problem building dev/e1000 To: Ian Lepore Cc: Enji Cooper , Eric Joyner , Robert Huff , FreeBSD Current X-Rspamd-Queue-Id: A095A816D9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 19:32:17 -0000 On Fri, Feb 15, 2019 at 12:17 PM Ian Lepore wrote: > On Fri, 2019-02-15 at 10:53 -0800, Enji Cooper wrote: > > > On Feb 15, 2019, at 10:46, Eric Joyner wrote: > > > > > > ifdi_if.h is a system generated interface file that network drivers > > > that depend on iflib use. It's generated from ifdi_if.m in sys/net. > > > > > > My guess is that you don't have "device iflib" defined in your > > > kernel configuration. em(4) depends on iflib in FreeBSD 12/13, and > > > with r343617, iflib is now explicitly a module that needs to be > > > included in your kernel config if you want to use a driver that > > > depends on it. It's already in the GENERIC kernel for amd64; are > > > you using a kernel config file that doesn't inherit from GENERIC? > > > > HO Eric! > > > > iflib was a recently added requirement on stable/12 IIRC..? > > > > Does the manpage note this dependency, and is there an UPDATING entry > > for this change? > > > > Thanks! > > -Enji > > > > My question would be: why? If some drivers have a new dependency on > iflib, why isn't that expressed in sys/conf/files and handled > automatically? > Right now we have files:net/iflib.c optional ether pci iflib in the files file. This would need to change to files:net/iflib.c optional ether pci (em | igb | ...) but we don't have a () operator in config. Or we'd need dozens of lines, and the duplicate elimination code in config has been tricky (though I didn't check it just now). Warner