From nobody Tue Mar 24 10:39:00 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fg63859Fkz6WTrn for ; Tue, 24 Mar 2026 10:39:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fg6382wPMz3thZ for ; Tue, 24 Mar 2026 10:39:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774348740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7ZRF6R0qLX4NpDMmhPzZmJ1HNxwkY1yHC+feY4l+qnU=; b=lRWi2JLHBPHe3HArWMuMSPekiibla8c2jQ/XlWyzw2C3D0Zi4++MBkgLR9GmRGIN6qvy1s DhvTd4hccm+dSnlzwoXDnrfFcjE0YYF8XPZ7zBfdZAjJck4FnKCBBKn3qMfhAQIS2uKLrA MvgnTIRHmz9pRpSyV47SunjrEqnd4HyBwlUd5g9UHoeC0vT7APXYWmsneIK99y9yLrAw0D ScccBojYJhsG9tFRDT9SlPlvHEiieU4TTU9IsFGA/jNRcNFunT6DnnxhItzr9nqTNjU3PI gCqJ2+00uXIaL+VAITLyNW1YwAtWjyLFu+IHFIEN3HXvqUyIXtpqyrxbbUNZBA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774348740; a=rsa-sha256; cv=none; b=S3KeAmc6bulpJIZdFV618gmybrCVikEbd6fKj+JaOMq7qzLP54+eBw43j36wuVhF2i7YgP vTZMfakd0FlhssTVZWuYph2JJzUBc9fcP4hS2/vY3CyiJdUkHqxy25lVraj/v+0LXkWbE4 5cJXbpBWdzfVLpJh6r1k3zyWXsd4dSAT1TJ28cik6tFQ0J5jSsOhpLheaRYiCHEbDjgA97 POVqCU3fZBs8vZtimcNf/W+X6IPN18Cr7FFKemP4GP62A1MgjJWPKS6bS4KVZMyCP8SdbX t+W/EIe7+y7T30vsCq/RTG2i0AxfSuCfxw9BKaM22k70wgoxbFuiIjZraESUAQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774348740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7ZRF6R0qLX4NpDMmhPzZmJ1HNxwkY1yHC+feY4l+qnU=; b=ONfwfimiJ9903HhBN1xxvN+ZCs5GCvoAZFLRIn0uL1q6gfx3u6HeA9AkmxVmjz2bVWwiSu YZ5yaLtePedgITGJEJUaf3hhEp1xOPf4ihRyulagn/a7UPPCV6b14zHl7HlnJruo28yDDQ YtE51UMGxxsCImSFkTPjplS8DJl7tLnjMDCKK3PPxcS/C85kY8nQX2GamzPZuX5kp1c5YR ms54yOq/4N2WJHCKjr5HU/wdwxfXra85zNJHc7e4rH+cX6dsPbiKpfyOR/B0v1tapCLff2 DLGCQzA/sKf7bve+31OqTtHRx97kc8cxcKjHB9+eDdnf6RHdINRGiOcn4hlUYQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fg6382SfHzb8 for ; Tue, 24 Mar 2026 10:39:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32aab by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Mar 2026 10:39:00 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: b9f9fc473eb5 - main - sound: Do not create root feeder in chn_init() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b9f9fc473eb56273978df4d4c889acba2862b21c Auto-Submitted: auto-generated Date: Tue, 24 Mar 2026 10:39:00 +0000 Message-Id: <69c269c4.32aab.3c8290a3@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=b9f9fc473eb56273978df4d4c889acba2862b21c commit b9f9fc473eb56273978df4d4c889acba2862b21c Author: Christos Margiolis AuthorDate: 2026-03-24 10:31:43 +0000 Commit: Christos Margiolis CommitDate: 2026-03-24 10:38:40 +0000 sound: Do not create root feeder in chn_init() The feeder chain gets destroyed when feeder_chain() is called, which is after the chn_reset() call in chn_init() further down for primary chans, or vchan_create() for vchans. This makes the root feeder creation in chn_init() essentially a no-op. Remove it altogether and let feeder_chain() after chn_reset() take care of creating the feeder properly. It creates the root one as well. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55941 --- sys/dev/sound/pcm/channel.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/sys/dev/sound/pcm/channel.c b/sys/dev/sound/pcm/channel.c index b74f76fd21ca..5e7c5772af01 100644 --- a/sys/dev/sound/pcm/channel.c +++ b/sys/dev/sound/pcm/channel.c @@ -1144,7 +1144,6 @@ chn_init(struct snddev_info *d, struct pcm_channel *parent, kobj_class_t cls, int dir, void *devinfo) { struct pcm_channel *c; - struct feeder_class *fc; struct snd_dbuf *b, *bs; char buf[CHN_NAMELEN]; int err, i, direction, *vchanrate, *vchanformat; @@ -1217,17 +1216,6 @@ chn_init(struct snddev_info *d, struct pcm_channel *parent, kobj_class_t cls, chn_vpc_reset(c, SND_VOL_C_PCM, 1); CHN_UNLOCK(c); - fc = feeder_getclass(FEEDER_ROOT); - if (fc == NULL) { - device_printf(d->dev, "%s(): failed to get feeder class\n", - __func__); - goto fail; - } - if (feeder_add(c, fc, NULL)) { - device_printf(d->dev, "%s(): failed to add feeder\n", __func__); - goto fail; - } - b = sndbuf_create(c, "primary"); bs = sndbuf_create(c, "secondary"); if (b == NULL || bs == NULL) {