From owner-freebsd-net@FreeBSD.ORG Tue Jul 1 09:25:06 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE733106567F; Tue, 1 Jul 2008 09:25:06 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 946F48FC1C; Tue, 1 Jul 2008 09:25:06 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id BB33841C795; Tue, 1 Jul 2008 11:25:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id oWqrVf1XDQB2; Tue, 1 Jul 2008 11:25:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 5619A41C758; Tue, 1 Jul 2008 11:25:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 60BB744487F; Tue, 1 Jul 2008 09:24:59 +0000 (UTC) Date: Tue, 1 Jul 2008 09:24:59 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Andre Oppermann In-Reply-To: <20080701084933.W57089@maildrop.int.zabbadoz.net> Message-ID: <20080701092254.T57089@maildrop.int.zabbadoz.net> References: <4852E23E.2040505@gtcomm.net> <4854EBF1.7020708@FreeBSD.org> <200807010606.m6166jFe084204@lava.sentex.ca> <4869EC1E.8060009@freebsd.org> <20080701084933.W57089@maildrop.int.zabbadoz.net> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-net@freebsd.org, Mike Tancsa , "Bruce M. Simpson" , Paul Subject: Re: Route messages X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jul 2008 09:25:07 -0000 On Tue, 1 Jul 2008, Bjoern A. Zeeb wrote: Hi, > On Tue, 1 Jul 2008, Andre Oppermann wrote: > > Hi, > >> Mike Tancsa wrote: >>> I am thinking >>> >>> http://lists.freebsd.org/pipermail/cvs-src/2008-April/090303.html >>> is the commit ? If I revert to the prev version, the issue goes away. > > Ha, I finally know why I ended up on Cc: of a thread I had no idea > about. Someone could have told me instead of blindly adding me;-) > > >> Yes, this change doesn't look right. It should only do the route >> lookup in ip_input.c when there was an EMSGSIZE error returned by >> ip_output(). The rtalloc_ign() call causes the message to be sent >> because it always sets report to one. The default message is RTM_MISS. >> >> I'll try to prep an updated patch which doesn't have these issues later >> today. > > Yeah my bad. Sorry. > > If you do that, do not do an extra route lookup if possible, correct > the rtalloc call. Thanks. So I had a very quick look at the code between doing something else. I think the only change needed is this if I am not mistaken but my head is far away nowhere close enough in this code. Andre, could you review this? Index: sys/netinet/ip_input.c =================================================================== RCS file: /shared/mirror/FreeBSD/r/ncvs/src/sys/netinet/ip_input.c,v retrieving revision 1.332.2.2 diff -u -p -r1.332.2.2 ip_input.c --- sys/netinet/ip_input.c 22 Apr 2008 12:02:55 -0000 1.332.2.2 +++ sys/netinet/ip_input.c 1 Jul 2008 09:23:08 -0000 @@ -1363,7 +1363,6 @@ ip_forward(struct mbuf *m, int srcrt) * the ICMP_UNREACH_NEEDFRAG "Next-Hop MTU" field described in RFC1191. */ bzero(&ro, sizeof(ro)); - rtalloc_ign(&ro, RTF_CLONING); error = ip_output(m, NULL, &ro, IP_FORWARDING, NULL, NULL); -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.